Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: Source/bindings/v8/V8ScriptRunner.cpp

Issue 19596004: Allow sites to enable 'window.onerror' handlers for cross-domain scripts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rework. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8ScriptRunner.cpp
diff --git a/Source/bindings/v8/V8ScriptRunner.cpp b/Source/bindings/v8/V8ScriptRunner.cpp
index a938a5e70aeabfa033d0ed8f6ab9d6ce3a057f4f..a0a007ad722f14c5d8ebddb78985cfeca021e295 100644
--- a/Source/bindings/v8/V8ScriptRunner.cpp
+++ b/Source/bindings/v8/V8ScriptRunner.cpp
@@ -63,14 +63,16 @@ PassOwnPtr<v8::ScriptData> V8ScriptRunner::precompileScript(v8::Handle<v8::Strin
return scriptData.release();
}
-v8::Local<v8::Script> V8ScriptRunner::compileScript(v8::Handle<v8::String> code, const String& fileName, const TextPosition& scriptStartPosition, v8::ScriptData* scriptData, v8::Isolate* isolate)
+v8::Local<v8::Script> V8ScriptRunner::compileScript(v8::Handle<v8::String> code, const String& fileName, const TextPosition& scriptStartPosition, v8::ScriptData* scriptData, v8::Isolate* isolate, ScriptAccessControlCheckStatus corsStatus)
{
TRACE_EVENT0("v8", "v8.compile");
TRACE_EVENT_SCOPED_SAMPLING_STATE("V8", "Compile");
v8::Handle<v8::String> name = v8String(fileName, isolate);
v8::Handle<v8::Integer> line = v8::Integer::New(scriptStartPosition.m_line.zeroBasedInt(), isolate);
v8::Handle<v8::Integer> column = v8::Integer::New(scriptStartPosition.m_column.zeroBasedInt(), isolate);
- v8::ScriptOrigin origin(name, line, column);
+ v8::Handle<v8::Boolean> isSharedCrossOrigin = corsStatus == ScriptIsSharedCrossOrigin ? v8::True() : v8::False();
+ printf("V8ScriptRunner::CompileScript: corsStatus == ScriptIsSharedCrossOrigin %s\n", corsStatus == ScriptIsSharedCrossOrigin? "true!" : "false!");
abarth-chromium 2013/08/05 22:31:45 We should probably remove this printf before landi
Mike West 2013/08/06 06:53:07 Ah. Right. *ahem* https://codereview.chromium.org/
+ v8::ScriptOrigin origin(name, line, column, isSharedCrossOrigin);
return v8::Script::Compile(code, &origin, scriptData);
}

Powered by Google App Engine
This is Rietveld 408576698