Source/core/dom/ScriptExecutionContext.h - Issue 19596004: Allow sites to enable 'window.onerror' handlers for cross-domain scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ScriptExecutionContext.h

Issue 19596004: Allow sites to enable 'window.onerror' handlers for cross-domain scripts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rework. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8ScriptRunner.cpp ('K') | « Source/bindings/v8/V8ScriptRunner.cpp ('k') | Source/core/dom/ScriptExecutionContext.cpp » ('j') | Source/core/dom/ScriptExecutionContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ScriptExecutionContext.h

diff --git a/Source/core/dom/ScriptExecutionContext.h b/Source/core/dom/ScriptExecutionContext.h

index fcbd20848683f9cfa48aa6837ee68ccfe90f2bc7..131f26de24ee2cc1fce9f7d89f7d0ef3fc64e65a 100644

--- a/Source/core/dom/ScriptExecutionContext.h

+++ b/Source/core/dom/ScriptExecutionContext.h

@@ -30,6 +30,7 @@

#include "core/dom/ActiveDOMObject.h"

#include "core/dom/SecurityContext.h"

+#include "core/loader/CrossOriginAccessControl.h"

#include "core/page/ConsoleTypes.h"

#include "core/page/DOMTimer.h"

#include "core/platform/LifecycleContext.h"

@@ -68,8 +69,8 @@ public:

virtual void disableEval(const String& errorMessage) = 0;

- bool sanitizeScriptError(String& errorMessage, int& lineNumber, int& columnNumber, String& sourceURL);

- void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, PassRefPtr<ScriptCallStack>);

+ bool sanitizeScriptError(String& errorMessage, int& lineNumber, int& columnNumber, String& sourceURL, ScriptAccessControlCheckStatus = ScriptIsNotSharedCrossOrigin);

+ void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, PassRefPtr<ScriptCallStack>, ScriptAccessControlCheckStatus = ScriptIsNotSharedCrossOrigin);

void addConsoleMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState* = 0, unsigned long requestIdentifier = 0);

virtual void addConsoleMessage(MessageSource, MessageLevel, const String& message, unsigned long requestIdentifier = 0) = 0;

@@ -156,7 +157,7 @@ private:

virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtr<ScriptCallStack>, ScriptState* = 0, unsigned long requestIdentifier = 0) = 0;

virtual EventTarget* errorEventTarget() = 0;

virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) = 0;

- bool dispatchErrorEvent(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL);

+ bool dispatchErrorEvent(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, ScriptAccessControlCheckStatus = ScriptIsNotSharedCrossOrigin);

void closeMessagePorts();