Issue 19580003: Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19580003: Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned. (Closed)

Created:
7 years, 5 months ago by bsalomon

Modified:
7 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned. BUG=260708 Committed: http://code.google.com/p/skia/source/detail?r=10132

Patch Set 2 : fix #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -23 lines)			Patch
M	src/gpu/gl/GrGLRenderTarget.h	View		1 chunk	+1 line, -1 line	1 comment	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View		2 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

It's not safe to rely on GrResource::onRelease() to free an owned object. It doesn't get ...

7 years, 5 months ago (2013-07-17 14:07:47 UTC) #1

robertphillips

lgtm + 1 question https://codereview.chromium.org/19580003/diff/2001/src/gpu/gl/GrGLRenderTarget.h File src/gpu/gl/GrGLRenderTarget.h (right): https://codereview.chromium.org/19580003/diff/2001/src/gpu/gl/GrGLRenderTarget.h#newcode99 src/gpu/gl/GrGLRenderTarget.h:99: // non-NULL if this RT ...

7 years, 5 months ago (2013-07-17 14:13:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/19580003/2001

7 years, 5 months ago (2013-07-17 14:24:27 UTC) #3

Message was sent while issue was closed.

Change committed as 10132

Expand Messages | Collapse Messages

Issue 19580003: Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix #

Messages