Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19579008: Revert "Revert 210138 "Perform glReadPixels with PBOs in the gpu, if PBO..."" (Closed)

Created:
7 years, 5 months ago by hubbe
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Revert "Revert 210138 "Perform glReadPixels with PBOs in the gpu, if PBO..."" Third try for getting asynchrous readpixels to work everywhere. This is identical to: https://codereview.chromium.org/16831004/, but with the following fixes: OutOfProcessPPAPITests.Graphics3D (removed a check in query_tracker.cc) GLReadbackTest.ReadPixelsWithPBO (removed, no longer a valid test) GLReadbackTest.ReadPixelsWithPBOAndQuery (now uses the correct query) And, new in this CL: Disable asynchronous readpixels on macosx prior to 10.8, as it would seem that the GL_ARB_fence extension doesn't seem to work on any driver, and there are crashes in readpixel itself on intel drivers. The original CL only disabled the async readpixels path for intel drivers. BUG=258169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213261

Patch Set 1 #

Patch Set 2 : previous upload reverts the revert, here are the changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -153 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 4 chunks +51 lines, -29 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 4 chunks +9 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +12 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 14 chunks +162 lines, -46 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 7 chunks +28 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 2 chunks +60 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_readback_unittests.cc View 1 3 chunks +25 lines, -35 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hubbe
7 years, 5 months ago (2013-07-22 22:25:59 UTC) #1
piman
LGTM
7 years, 5 months ago (2013-07-22 22:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/19579008/2001
7 years, 5 months ago (2013-07-22 23:38:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150776
7 years, 5 months ago (2013-07-23 01:28:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/19579008/2001
7 years, 5 months ago (2013-07-23 05:21:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151018
7 years, 5 months ago (2013-07-23 05:58:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/19579008/2001
7 years, 5 months ago (2013-07-23 22:45:53 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 23:17:57 UTC) #8
Message was sent while issue was closed. 
Change committed as 213261

Powered by Google App Engine
This is Rietveld 408576698