media: Move widevine CDM targets to WidevineCdm folder

chrome/BUILD.gn

Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 65dc4d59aa6dabfa8f7c89e7d13f361758e78ca7..a51bf1bcd3e9f4bef3c219f52ae058e230929ea8 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -223,9 +223,10 @@ if (!is_android && !is_mac) {
       # On Mac, internal plugins go inside the framework, so these
       # dependencies are on chrome.dll.
       "//third_party/adobe/flash:flapper_binaries",
-      "//third_party/widevine/cdm:widevinecdmadapter",
     ]
 
+    data_deps += [ "//third_party/widevine/cdm:widevinecdmadapter" ]

[ddorwin, 2016/05/06 22:23:48]

What is the reason for this change? Note that the flash_binaries end up in a
PepperFlash/ directory.

[xhwang, 2016/05/09 20:59:02]

widevinecdmadapter is a shared_library, the current "deps" is causing chrome
binary to depend on widevinecdmadapter at run time, which isn't desired. Also,
after https://codereview.chromium.org/1525773002/, the rpath is not specified by
default for non-component build, so I actually saw an error where chrome cannot
be loaded because widevinecdmadapter can't be find, unless I specify
LD_LIBRARY_PATH.

Since chrome only need the widevinecdmadapter as a plugin, it makes more sense
to specify it as a data_deps.

[ddorwin, 2016/05/09 23:12:56]

Thanks. I wonder whether the flapper_binaries should also be data_deps instead.
Perhaps something to ask the GN/Flash people.

[xhwang, 2016/05/09 23:50:05]

flapper_binaries is "copy" action [1], which will not force dependants to link
to it [2]. But I agree data_deps is probably more appropriate.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/adobe/...

[2]
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

  Executables, shared libraries, and complete static libraries will
  link all propagated targets and stop propagation. Actions and copy
  steps also stop propagation, allowing them to take a library as an
  input but not force dependants to link to it.

+
     if (is_multi_dll_chrome) {
       defines += [ "CHROME_MULTIPLE_DLL" ]
       data_deps += [ ":chrome_child" ]