media: Move widevine CDM targets to WidevineCdm folder

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
 import("//build/config/sanitizers/sanitizers.gni")
@@ skipping 205 matching lines @@
       ":packed_extra_resources",
       ":packed_resources",
     ]
     deps += [
       "//components/startup_metric_utils/browser:lib",
 
       # Precompiled plugins that need to get copied to the output directory.
       # On Mac, internal plugins go inside the framework, so these
       # dependencies are on chrome.dll.
       "//third_party/adobe/flash:flapper_binaries",
-      "//third_party/widevine/cdm:widevinecdmadapter",
     ]
 
+    data_deps += [ "//third_party/widevine/cdm:widevinecdmadapter" ]

[ddorwin, 2016/05/06 22:23:48]

What is the reason for this change? Note that the flash_binaries end up in a
PepperFlash/ directory.

[xhwang, 2016/05/09 20:59:02]

widevinecdmadapter is a shared_library, the current "deps" is causing chrome
binary to depend on widevinecdmadapter at run time, which isn't desired. Also,
after https://codereview.chromium.org/1525773002/, the rpath is not specified by
default for non-component build, so I actually saw an error where chrome cannot
be loaded because widevinecdmadapter can't be find, unless I specify
LD_LIBRARY_PATH.

Since chrome only need the widevinecdmadapter as a plugin, it makes more sense
to specify it as a data_deps.

[ddorwin, 2016/05/09 23:12:56]

Thanks. I wonder whether the flapper_binaries should also be data_deps instead.
Perhaps something to ask the GN/Flash people.

[xhwang, 2016/05/09 23:50:05]

flapper_binaries is "copy" action [1], which will not force dependants to link
to it [2]. But I agree data_deps is probably more appropriate.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/adobe/...

[2]
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

  Executables, shared libraries, and complete static libraries will
  link all propagated targets and stop propagation. Actions and copy
  steps also stop propagation, allowing them to take a library as an
  input but not force dependants to link to it.

+
     if (is_multi_dll_chrome) {
       defines += [ "CHROME_MULTIPLE_DLL" ]
       data_deps += [ ":chrome_child" ]
     }
   }
 }  # !is_android && !is_mac
 
 if (is_mac) {
   if (is_component_build) {
     # On Mac component builds, this target is the bundle, and the main dll is
@@ skipping 1133 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }