Clean up TranslateManager's URL fetchers so that they are destroyed in the correct thread.

Clean up TranslateManager's URL fetchers so that they are destroyed in the correct thread.

BUG=263240
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213341

[hajimehoshi, 2013-07-23 09:29:45]

Can you take a look?  Thank you in advance.

I added cbentzel@ as a reviewer because of
https://codereview.chromium.org/7246010.

[Takashi Toyoshima, 2013-07-23 10:21:31]

translate/ LGTM

[jochen (gone - plz use gerrit), 2013-07-23 11:13:55]

lgtm

[cbentzel, 2013-07-23 14:16:39]

LGTM

[commit-bot: I haz the power, 2013-07-24 00:29:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/19555005/1

[commit-bot: I haz the power, 2013-07-24 04:54:10]

Change committed as 213341

[dgrogan, 2013-07-24 19:19:54]

I'm going to revert this because it is causing flakiness on the try bots, e.g.
http://build.chromium.org/p/tryserver.chromium/builders/linux_aura/builds/629...

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3448 ms total)
[  PASSED  ] 1 test.
Note: Google Test filter =
TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from TranslateManagerBrowserTest
[ RUN      ] TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage
Xlib:  extension "RANDR" missing on display ":9".
[       OK ] TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage (84
ms)
[----------] 1 test from TranslateManagerBrowserTest (84 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (84 ms total)
[  PASSED  ] 1 test.
[21065:21065:0724/112031:332428932828:FATAL:translate_manager.cc(88)] Check
failed: language_list_.get() == NULL. 
[21065:21065:0724/112031:332428932828:FATAL:translate_manager.cc(88)] Check
failed: language_list_.get() == NULL.

[hajimehoshi, 2013-07-25 04:14:03]

Oops, thanks.  I should have realized this the result of trybots of this CL.

On 2013/07/24 19:19:54, dgrogan wrote:
> I'm going to revert this because it is causing flakiness on the try bots, e.g.
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_aura/builds/629...
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (3448 ms total)
> [  PASSED  ] 1 test.
> Note: Google Test filter =
> TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from TranslateManagerBrowserTest
> [ RUN      ] TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage
> Xlib:  extension "RANDR" missing on display ":9".
> [       OK ] TranslateManagerBrowserTest.ServerReportsUnsupportedLanguage (84
> ms)
> [----------] 1 test from TranslateManagerBrowserTest (84 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (84 ms total)
> [  PASSED  ] 1 test.
> [21065:21065:0724/112031:332428932828:FATAL:translate_manager.cc(88)] Check
> failed: language_list_.get() == NULL. 
> [21065:21065:0724/112031:332428932828:FATAL:translate_manager.cc(88)] Check
> failed: language_list_.get() == NULL.