Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8738)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 19555005: Clean up TranslateManager's URL fetchers so that they are destroyed in the correct thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 057084e3b9950effa69673d29dd0736f721a0350..70d9210d1b0f84aaddc113446baf5d5875bb2324 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -84,6 +84,10 @@ const int kMaxTranslateLoadCheckAttempts = 20;
} // namespace
TranslateManager::~TranslateManager() {
+ // CleanupPendingUrlFetcher should be called ahead of destructing.
+ DCHECK(language_list_.get() == NULL);
+ DCHECK(script_.get() == NULL);
+
weak_method_factory_.InvalidateWeakPtrs();
}
@@ -634,7 +638,7 @@ void TranslateManager::FetchLanguageListFromTranslateServer(
NOTREACHED();
}
-void TranslateManager::CleanupPendingUlrFetcher() {
+void TranslateManager::CleanupPendingUrlFetcher() {
language_list_.reset();
script_.reset();
}
« no previous file with comments | « chrome/browser/translate/translate_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698