Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 19541006: only use gold-specific flags for the target linker (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
Reviewers:
danakj, Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

only use gold-specific flags for the target linker The host linker might not be gold if linux_use_gold_binary==0, eg where we have a cross toolchain with gold and we want to use that instead of third_party/gold/gold64. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mostyn Bramley-Moore
PTAL...
7 years, 5 months ago (2013-07-19 10:45:29 UTC) #1
Sam Clegg
On 2013/07/19 10:45:29, Mostyn Bramley-Moore wrote: > PTAL... So this means we never get multi-threaded ...
7 years, 5 months ago (2013-07-19 18:52:39 UTC) #2
Mostyn Bramley-Moore
> So this means we never get multi-threaded linking for host binary? Is that > ...
7 years, 5 months ago (2013-07-19 23:16:57 UTC) #3
Sam Clegg
ok, lgtm.
7 years, 5 months ago (2013-07-20 00:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/19541006/1
7 years, 5 months ago (2013-07-20 19:09:02 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-20 19:41:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/19541006/1
7 years, 5 months ago (2013-07-21 13:16:00 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 14:03:35 UTC) #8
Message was sent while issue was closed.
Change committed as 212823

Powered by Google App Engine
This is Rietveld 408576698