Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: build/common.gypi

Issue 19541006: only use gold-specific flags for the target linker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3360 matching lines...) Expand 10 before | Expand all | Expand 10 after
3371 ['linux_keep_shadow_stacks==1', { 3371 ['linux_keep_shadow_stacks==1', {
3372 'defines': ['KEEP_SHADOW_STACKS'], 3372 'defines': ['KEEP_SHADOW_STACKS'],
3373 'cflags': [ 3373 'cflags': [
3374 '-finstrument-functions', 3374 '-finstrument-functions',
3375 # Allow mmx intrinsics to inline, so that the compiler can expand 3375 # Allow mmx intrinsics to inline, so that the compiler can expand
3376 # the intrinsics. 3376 # the intrinsics.
3377 '-finstrument-functions-exclude-file-list=mmintrin.h', 3377 '-finstrument-functions-exclude-file-list=mmintrin.h',
3378 ], 3378 ],
3379 }], 3379 }],
3380 ['linux_use_gold_flags==1', { 3380 ['linux_use_gold_flags==1', {
3381 'ldflags': [ 3381 'target_conditions': [
3382 # Experimentation found that using four linking threads 3382 ['_toolset=="target"', {
3383 # saved ~20% of link time. 3383 'ldflags': [
3384 # https://groups.google.com/a/chromium.org/group/chromium-dev/brow se_thread/thread/281527606915bb36 3384 # Experimentation found that using four linking threads
3385 '-Wl,--threads', 3385 # saved ~20% of link time.
3386 '-Wl,--thread-count=4', 3386 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
3387 # Only apply this to the target linker, since the host
3388 # linker might not be gold, but isn't used much anyway.
3389 '-Wl,--threads',
3390 '-Wl,--thread-count=4',
3391 ],
3392 }],
3387 ], 3393 ],
3388 'conditions': [ 3394 'conditions': [
3389 ['release_valgrind_build==0', { 3395 ['release_valgrind_build==0', {
3390 'target_conditions': [ 3396 'target_conditions': [
3391 ['_toolset=="target"', { 3397 ['_toolset=="target"', {
3392 'ldflags': [ 3398 'ldflags': [
3393 # There seems to be a conflict of --icf and -pie 3399 # There seems to be a conflict of --icf and -pie
3394 # in gold which can generate crashy binaries. As 3400 # in gold which can generate crashy binaries. As
3395 # a security measure, -pie takes precendence for 3401 # a security measure, -pie takes precendence for
3396 # now. 3402 # now.
(...skipping 1254 matching lines...) Expand 10 before | Expand all | Expand 10 after
4651 # settings in target dicts. SYMROOT is a special case, because many other 4657 # settings in target dicts. SYMROOT is a special case, because many other
4652 # Xcode variables depend on it, including variables such as 4658 # Xcode variables depend on it, including variables such as
4653 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4659 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4654 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4660 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4655 # files to appear (when present) in the UI as actual files and not red 4661 # files to appear (when present) in the UI as actual files and not red
4656 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4662 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4657 # and therefore SYMROOT, needs to be set at the project level. 4663 # and therefore SYMROOT, needs to be set at the project level.
4658 'SYMROOT': '<(DEPTH)/xcodebuild', 4664 'SYMROOT': '<(DEPTH)/xcodebuild',
4659 }, 4665 },
4660 } 4666 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698