Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: Source/core/html/FormController.h

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/FileInputType.cpp ('k') | Source/core/html/FormController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/FormController.h
diff --git a/Source/core/html/FormController.h b/Source/core/html/FormController.h
index 551e058095f886c724560785493b6aa504ad587d..920878e95f5c2a6a5ed7bc0eea5b2cf30353727a 100644
--- a/Source/core/html/FormController.h
+++ b/Source/core/html/FormController.h
@@ -84,14 +84,14 @@ public:
CheckedRadioButtons& checkedRadioButtons() { return m_checkedRadioButtons; }
- void registerFormElementWithState(HTMLFormControlElementWithState* control) { m_formElementsWithState.add(control); }
- void unregisterFormElementWithState(HTMLFormControlElementWithState* control) { m_formElementsWithState.remove(control); }
+ void registerFormElementWithState(Handle<HTMLFormControlElementWithState> control) { m_formElementsWithState.add(control.raw()); }
+ void unregisterFormElementWithState(Handle<HTMLFormControlElementWithState> control) { m_formElementsWithState.remove(control.raw()); }
// This should be callled only by Document::formElementsState().
Vector<String> formElementsState() const;
// This should be callled only by Document::setStateForNewFormElements().
void setStateForNewFormElements(const Vector<String>&);
void willDeleteForm(HTMLFormElement*);
- void restoreControlStateFor(HTMLFormControlElementWithState&);
+ void restoreControlStateFor(Handle<HTMLFormControlElementWithState>);
void restoreControlStateIn(HTMLFormElement&);
static Vector<String> getReferencedFilePaths(const Vector<String>& stateVector);
@@ -99,12 +99,13 @@ public:
void clearWeakPointers(Visitor*);
private:
+ // FIXME(oilpan): This should be a weak hash set.
typedef ListHashSet<HTMLFormControlElementWithState*, 64> FormElementListHashSet;
typedef HashMap<RefPtr<AtomicStringImpl>, OwnPtr<SavedFormState> > SavedFormStateMap;
FormController();
static PassOwnPtr<SavedFormStateMap> createSavedFormStateMap(const FormElementListHashSet&);
- FormControlState takeStateForFormElement(const HTMLFormControlElementWithState&);
+ FormControlState takeStateForFormElement(Handle<const HTMLFormControlElementWithState>);
static void formStatesFromStateVector(const Vector<String>&, SavedFormStateMap&);
CheckedRadioButtons m_checkedRadioButtons;
« no previous file with comments | « Source/core/html/FileInputType.cpp ('k') | Source/core/html/FormController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698