Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: Source/core/html/FileInputType.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/FileInputType.h ('k') | Source/core/html/FormController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/FileInputType.cpp
diff --git a/Source/core/html/FileInputType.cpp b/Source/core/html/FileInputType.cpp
index b61e2cb2720a167bc684c1f415070d2d163466e6..2eb2063de32ed148d7581291e8e935930efbbd28 100644
--- a/Source/core/html/FileInputType.cpp
+++ b/Source/core/html/FileInputType.cpp
@@ -87,13 +87,13 @@ const AtomicString& UploadButtonElement::shadowPseudoId() const
return pseudoId;
}
-inline FileInputType::FileInputType(HTMLInputElement* element)
+inline FileInputType::FileInputType(Handle<HTMLInputElement> element)
: BaseClickableWithKeyInputType(element)
, m_fileList(FileList::create())
{
}
-PassOwnPtr<InputType> FileInputType::create(HTMLInputElement* element)
+PassOwnPtr<InputType> FileInputType::create(Handle<HTMLInputElement> element)
{
return adoptPtr(new FileInputType(element));
}
@@ -184,7 +184,7 @@ void FileInputType::handleDOMActivateEvent(Event* event)
if (Chrome* chrome = this->chrome()) {
FileChooserSettings settings;
- HTMLInputElement* input = element();
+ Handle<HTMLInputElement> input = element();
settings.allowsDirectoryUpload = RuntimeEnabledFeatures::directoryUploadEnabled() && input->fastHasAttribute(webkitdirectoryAttr);
settings.allowsMultipleFiles = settings.allowsDirectoryUpload || input->fastHasAttribute(multipleAttr);
settings.acceptMIMETypes = input->acceptMIMETypes();
@@ -330,7 +330,7 @@ void FileInputType::setFiles(PassRefPtr<FileList> files)
if (!files)
return;
- RefPtr<HTMLInputElement> input = element();
+ Handle<HTMLInputElement> input = element();
bool pathsChanged = false;
if (files->length() != m_fileList->length())
@@ -375,7 +375,7 @@ void FileInputType::receiveDropForDirectoryUpload(const Vector<String>& paths)
{
if (Chrome* chrome = this->chrome()) {
FileChooserSettings settings;
- HTMLInputElement* input = element();
+ Handle<HTMLInputElement> input = element();
settings.allowsDirectoryUpload = true;
settings.allowsMultipleFiles = true;
settings.selectedFiles.append(paths[0]);
@@ -402,7 +402,7 @@ bool FileInputType::receiveDroppedFiles(const DragData* dragData)
if (paths.isEmpty())
return false;
- HTMLInputElement* input = element();
+ Handle<HTMLInputElement> input = element();
if (input->fastHasAttribute(webkitdirectoryAttr) && RuntimeEnabledFeatures::directoryUploadEnabled()) {
receiveDropForDirectoryUpload(paths);
return true;
« no previous file with comments | « Source/core/html/FileInputType.h ('k') | Source/core/html/FormController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698