Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: Source/core/html/InputType.h

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/ImageInputType.cpp ('k') | Source/core/html/InputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/InputType.h
diff --git a/Source/core/html/InputType.h b/Source/core/html/InputType.h
index 0d35e1b09834bad2cdb5b32d01cf4f24c8b4a8cd..1b95d3ee8f77a71ae83b385cbdff4b50ab6deb9c 100644
--- a/Source/core/html/InputType.h
+++ b/Source/core/html/InputType.h
@@ -67,12 +67,11 @@ class TouchEvent;
typedef int ExceptionCode;
struct ClickHandlingState {
- WTF_MAKE_FAST_ALLOCATED;
-
public:
bool checked;
bool indeterminate;
- RefPtr<HTMLInputElement> checkedRadioButton;
+ // FIXME(oilpan): Move ClickHandlingState to the heap and use a Member for this.
+ Persistent<HTMLInputElement> checkedRadioButton;
};
// An InputType object represents the type-specific part of an HTMLInputElement.
@@ -83,8 +82,8 @@ class InputType {
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<InputType> create(HTMLInputElement*, const AtomicString&);
- static PassOwnPtr<InputType> createText(HTMLInputElement*);
+ static PassOwnPtr<InputType> create(Handle<HTMLInputElement>, const AtomicString&);
+ static PassOwnPtr<InputType> createText(Handle<HTMLInputElement>);
virtual ~InputType();
static bool themeSupportsDataListUI(InputType*);
@@ -307,8 +306,8 @@ public:
void dispatchSimulatedClickIfActive(KeyboardEvent*) const;
protected:
- InputType(HTMLInputElement* element) : m_element(element) { }
- HTMLInputElement* element() const { return m_element; }
+ InputType(const Handle<HTMLInputElement>&);
+ Result<HTMLInputElement> element() const;
Chrome* chrome() const;
Decimal parseToNumberOrNaN(const String&) const;
void observeFeatureIfVisible(UseCounter::Feature) const;
@@ -317,7 +316,7 @@ private:
// Helper for stepUp()/stepDown(). Adds step value * count to the current value.
void applyStep(int count, AnyStepHandling, TextFieldEventBehavior, ExceptionCode&);
- // Raw pointer because the HTMLInputElement object owns this InputType object.
+ // FIXME(oilpan): Raw pointer because the HTMLInputElement object owns this InputType object.
HTMLInputElement* m_element;
};
« no previous file with comments | « Source/core/html/ImageInputType.cpp ('k') | Source/core/html/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698