Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextAreaElement.cpp
diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp
index 53ec84bab105ef2055935ce7a96196a3c1b5b2aa..0b4af172e455ed3eab71a8bacbe431c9e61037a7 100644
--- a/Source/core/html/HTMLTextAreaElement.cpp
+++ b/Source/core/html/HTMLTextAreaElement.cpp
@@ -100,11 +100,11 @@ HTMLTextAreaElement::HTMLTextAreaElement(const QualifiedName& tagName, Document*
ScriptWrappable::init(this);
}
-PassRefPtr<HTMLTextAreaElement> HTMLTextAreaElement::create(const QualifiedName& tagName, Document* document, HTMLFormElement* form)
+Result<HTMLTextAreaElement> HTMLTextAreaElement::create(const QualifiedName& tagName, Document* document, HTMLFormElement* form)
{
- RefPtr<HTMLTextAreaElement> textArea = adoptRef(new HTMLTextAreaElement(tagName, document, form));
+ Handle<HTMLTextAreaElement> textArea = adoptNode(new HTMLTextAreaElement(tagName, document, form));
textArea->ensureUserAgentShadowRoot();
- return textArea.release();
+ return textArea;
}
void HTMLTextAreaElement::didAddUserAgentShadowRoot(ShadowRoot* root)
@@ -561,4 +561,9 @@ void HTMLTextAreaElement::updatePlaceholderText()
fixPlaceholderRenderer(m_placeholder, innerTextElement());
}
+void HTMLTextAreaElement::acceptHeapVisitor(Visitor* visitor) const
+{
+ HTMLTextFormControlElement::acceptHeapVisitor(visitor);
+}
+
}

Powered by Google App Engine
This is Rietveld 408576698