Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.h
diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h
index 7adc4401b8b65b928e99e790e1782af7478a3499..14ea7d59ec66b02db3f40f7c237a1dfb3877e47e 100644
--- a/Source/core/html/HTMLInputElement.h
+++ b/Source/core/html/HTMLInputElement.h
@@ -45,12 +45,12 @@ struct DateTimeChooserParameters;
class HTMLInputElement : public HTMLTextFormControlElement {
public:
- static PassRefPtr<HTMLInputElement> create(const QualifiedName&, Document*, HTMLFormElement*, bool createdByParser);
+ static Result<HTMLInputElement> create(const QualifiedName&, Document*, HTMLFormElement*, bool createdByParser);
virtual ~HTMLInputElement();
DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitspeechchange);
- virtual HTMLInputElement* toInputElement() { return this; }
+ virtual Result<HTMLInputElement> toInputElement() { return Handle<HTMLInputElement>(this); }
virtual bool shouldAutocomplete() const;
@@ -205,7 +205,6 @@ public:
Vector<String> acceptMIMETypes();
Vector<String> acceptFileExtensions();
- String accept() const;
haraken 2013/07/17 14:10:23 This conflicts with our accept(). However, fortuna
Vyacheslav Egorov (Google) 2013/07/18 16:50:08 Nice! With this removed we might be even able to r
String alt() const;
void setSize(unsigned);
@@ -248,7 +247,7 @@ public:
void listAttributeTargetChanged();
#endif
- HTMLInputElement* checkedRadioButtonForGroup() const;
+ Result<HTMLInputElement> checkedRadioButtonForGroup() const;
bool isInRequiredRadioButtonGroup();
// Functions for InputType classes.
@@ -298,6 +297,8 @@ public:
bool setupDateTimeChooserParameters(DateTimeChooserParameters&);
virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
+ virtual void acceptHeapVisitor(Visitor*) const OVERRIDE;
+
protected:
HTMLInputElement(const QualifiedName&, Document*, HTMLFormElement*, bool createdByParser);

Powered by Google App Engine
This is Rietveld 408576698