Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: content/browser/web_contents/interstitial_page_impl.cc

Issue 19491004: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/interstitial_page_impl.cc
diff --git a/content/browser/web_contents/interstitial_page_impl.cc b/content/browser/web_contents/interstitial_page_impl.cc
index 4acea35204b929bc85d1e8a363e951a68c22fea8..f08b0c9b37d459cb10095fffca74a28c6774131c 100644
--- a/content/browser/web_contents/interstitial_page_impl.cc
+++ b/content/browser/web_contents/interstitial_page_impl.cc
@@ -493,7 +493,7 @@ RenderViewHost* InterstitialPageImpl::CreateRenderViewHost() {
DOMStorageContextImpl* dom_storage_context =
static_cast<DOMStorageContextImpl*>(BrowserContext::GetStoragePartition(
browser_context, site_instance.get())->GetDOMStorageContext());
- SessionStorageNamespaceImpl* session_storage_namespace_impl =
+ session_storage_namespace_ =
new SessionStorageNamespaceImpl(dom_storage_context);
RenderViewHostImpl* render_view_host =
@@ -502,8 +502,7 @@ RenderViewHost* InterstitialPageImpl::CreateRenderViewHost() {
this,
MSG_ROUTING_NONE,
MSG_ROUTING_NONE,
- false,
- session_storage_namespace_impl);
+ false);
web_contents_->RenderViewForInterstitialPageCreated(render_view_host);
return render_view_host;
}
@@ -704,6 +703,11 @@ void InterstitialPageImpl::ShowCreatedFullscreenWidget(int route_id) {
<< "InterstitialPage does not support showing full screen popups.";
}
+SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace(
+ SiteInstance* instance) {
+ return session_storage_namespace_.get();
+}
+
void InterstitialPageImpl::Disable() {
enabled_ = false;
}
« no previous file with comments | « content/browser/web_contents/interstitial_page_impl.h ('k') | content/browser/web_contents/render_view_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698