Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1941593002: Subzero: Suppress a warning as a result of an updated clang. (Closed)

Created:
4 years, 7 months ago by Jim Stichnoth
Modified:
4 years, 7 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Suppress a warning as a result of an updated clang. Also improve some diagnostic output in the Makefile. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7146e99715cfb65fc564068363f0a867e760408a

Patch Set 1 #

Patch Set 2 : Don't add the warning to pnacl-clang++ #

Patch Set 3 : Also fix the LLVM-side build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M CMakeLists.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Makefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Makefile.standalone View 1 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jim Stichnoth
4 years, 7 months ago (2016-05-01 00:49:04 UTC) #3
John
lgtm
4 years, 7 months ago (2016-05-01 02:05:12 UTC) #4
Jim Stichnoth
PTAL. Also, to clarify, this patch is necessary after doing: cd .../native_client git pull gclient ...
4 years, 7 months ago (2016-05-01 16:50:27 UTC) #5
John
lgtm
4 years, 7 months ago (2016-05-01 16:52:39 UTC) #6
Jim Stichnoth
4 years, 7 months ago (2016-05-02 19:06:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7146e99715cfb65fc564068363f0a867e760408a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698