Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1940683002: client/flagpb: fix unmarshaling of maps (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 7 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@flagpb-parse-value
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

client/flagpb: fix unmarshaling of maps Map type is special and supporting added complexity. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/d7f7aa9d3ca0fa0c00b00d7bef2d424282f358d9

Patch Set 1 #

Patch Set 2 : -mapcase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -30 lines) Patch
M client/flagpb/unmarshal.go View 1 3 chunks +24 lines, -11 lines 1 comment Download
M client/flagpb/unmarshal_test.desc View Binary file 0 comments Download
M client/flagpb/unmarshal_test.go View 2 chunks +24 lines, -3 lines 0 comments Download
M client/flagpb/unmarshal_test.proto View 1 chunk +6 lines, -0 lines 0 comments Download
M client/flagpb/unmarshal_test.pb_test.go View 2 chunks +57 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 1935923002 Patch 1

Messages

Total messages: 8 (3 generated)
nodir
4 years, 7 months ago (2016-04-30 03:58:51 UTC) #1
nodir
https://codereview.chromium.org/1940683002/diff/40001/client/flagpb/unmarshal.go File client/flagpb/unmarshal.go (right): https://codereview.chromium.org/1940683002/diff/40001/client/flagpb/unmarshal.go#newcode194 client/flagpb/unmarshal.go:194: } deduping this would causes an obscure abstraction
4 years, 7 months ago (2016-04-30 04:43:58 UTC) #3
Vadim Sh.
lgtm
4 years, 7 months ago (2016-05-01 18:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940683002/40001
4 years, 7 months ago (2016-05-01 21:58:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:53 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-go/commit/d7f7aa9d3ca0fa0c00b00d7bef2d424282f358d9

Powered by Google App Engine
This is Rietveld 408576698