Reset the Lo-Fi main frame state when there is a new main frame request

components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
index cbf79c38e874f14cf6d75a1dd84826462e67a478..a178b7a334c8fde68921afcc6a587c878284d478 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
@@ -153,6 +153,15 @@ DataReductionProxyNetworkDelegate::SessionNetworkStatsInfoToValue() const {
   return dict;
 }
 
+void DataReductionProxyNetworkDelegate::OnBeforeURLRequestInternal(
+    net::URLRequest* request,
+    const net::CompletionCallback& callback,
+    GURL* new_url) {
+  if ((request->load_flags() & net::LOAD_MAIN_FRAME)) {

[tbansal1, 2016/05/04 05:16:57]

braces not needed.

[tbansal1, 2016/05/04 05:16:57]

Is request guaranteed to be non-null here? I think so but please check.

[megjablon, 2016/05/06 22:13:00]

Yes, see
https://code.google.com/p/chromium/codesearch#chromium/src/net/base/network_d...

Added DCHECK

[megjablon, 2016/05/06 22:13:00]

Done.

+    data_reduction_proxy_io_data_->SetLoFiModeActiveOnMainFrame(false);
+  }
+}
+
 void DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal(
     net::URLRequest* request,
     const net::ProxyInfo& proxy_info,
@@ -170,7 +179,6 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal(
         data_reduction_proxy_config_);
 
     if ((request->load_flags() & net::LOAD_MAIN_FRAME)) {
-      // TODO(megjablon): Need to switch to per page.

[tbansal1, 2016/05/04 01:46:23]

Why is this TODO gone? Seems like the Lo-Fi state is still stored in
DRP_settings and retrieved using WasLoFiModeActiveOnMainFrame() by Java?

[megjablon, 2016/05/04 03:02:44]

This isn't going to be fixable. This TODO was added for the snackbar triggering
which has since been fixed by triggering on response. It is still being used by
context menus which are used much less than the snackbar, and the way a context
menu is generated has no tie to a page and we won't be putting in the effort to
fix this.

[tbansal1, 2016/05/04 05:16:57]

Acknowledged.

       data_reduction_proxy_io_data_->SetLoFiModeActiveOnMainFrame(
           is_using_lofi_mode);
     }