Reset the Lo-Fi main frame state when there is a new main frame request

components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h"
 
 #include <utility>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 135 matching lines @@
 DataReductionProxyNetworkDelegate::SessionNetworkStatsInfoToValue() const {
   base::DictionaryValue* dict = new base::DictionaryValue();
   // Use strings to avoid overflow. base::Value only supports 32-bit integers.
   dict->SetString("session_received_content_length",
                   base::Int64ToString(total_received_bytes_));
   dict->SetString("session_original_content_length",
                   base::Int64ToString(total_original_received_bytes_));
   return dict;
 }
 
+void DataReductionProxyNetworkDelegate::OnBeforeURLRequestInternal(
+    net::URLRequest* request,
+    const net::CompletionCallback& callback,
+    GURL* new_url) {
+  if ((request->load_flags() & net::LOAD_MAIN_FRAME)) {

[tbansal1, 2016/05/04 05:16:57]

braces not needed.

[tbansal1, 2016/05/04 05:16:57]

Is request guaranteed to be non-null here? I think so but please check.

[megjablon, 2016/05/06 22:13:00]

Yes, see
https://code.google.com/p/chromium/codesearch#chromium/src/net/base/network_d...

Added DCHECK

[megjablon, 2016/05/06 22:13:00]

Done.

+    data_reduction_proxy_io_data_->SetLoFiModeActiveOnMainFrame(false);
+  }
+}
+
 void DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal(
     net::URLRequest* request,
     const net::ProxyInfo& proxy_info,
     net::HttpRequestHeaders* headers) {
   DCHECK(data_reduction_proxy_config_);
 
   if (proxy_info.is_empty())

[tbansal1, 2016/05/04 05:16:56]

Is it useful to add a check here that proxy_info.proxy_server is DRP, and return
early if it is not?
Currently, it is checked separately two times below.

[megjablon, 2016/05/06 22:13:00]

Done.

     return;
 
   if (data_reduction_proxy_io_data_ &&
       data_reduction_proxy_io_data_->lofi_decider() && request) {
     LoFiDecider* lofi_decider = data_reduction_proxy_io_data_->lofi_decider();
     bool is_using_lofi_mode = lofi_decider->MaybeAddLoFiDirectiveToHeaders(
         *request, headers, proxy_info.proxy_server(),
         data_reduction_proxy_config_);
 
     if ((request->load_flags() & net::LOAD_MAIN_FRAME)) {
-      // TODO(megjablon): Need to switch to per page.

[tbansal1, 2016/05/04 01:46:23]

Why is this TODO gone? Seems like the Lo-Fi state is still stored in
DRP_settings and retrieved using WasLoFiModeActiveOnMainFrame() by Java?

[megjablon, 2016/05/04 03:02:44]

This isn't going to be fixable. This TODO was added for the snackbar triggering
which has since been fixed by triggering on response. It is still being used by
context menus which are used much less than the snackbar, and the way a context
menu is generated has no tie to a page and we won't be putting in the effort to
fix this.

[tbansal1, 2016/05/04 05:16:57]

Acknowledged.

       data_reduction_proxy_io_data_->SetLoFiModeActiveOnMainFrame(
           is_using_lofi_mode);
     }
   }
 
   if (data_reduction_proxy_request_options_) {
     data_reduction_proxy_request_options_->MaybeAddRequestHeader(
         proxy_info.proxy_server(), headers);
   }
 }
@@ skipping 130 matching lines @@
   }
 }
 
 void DataReductionProxyNetworkDelegate::RecordLoFiTransformationType(
     LoFiTransformationType type) {
   UMA_HISTOGRAM_ENUMERATION("DataReductionProxy.LoFi.TransformationType", type,
                             LO_FI_TRANSFORMATION_TYPES_INDEX_BOUNDARY);
 }
 
 }  // namespace data_reduction_proxy