Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1932363003: Remove net::IPAddressNumber. (Closed)

Created:
4 years, 7 months ago by martijnc
Modified:
4 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

All consumers have been migrated to net::IPAddress over the last months so it is now safe to remove the net::IPAddressNumber type. This also removes the IPAddress length constants and switches consumers to the (identically named) net::IPAddress member constants or the IsIPv*() helpers where possible. The other changes are mostly removals of leftover #includes. BUG=496258 Committed: https://crrev.com/56506d0a3226db78d2a905a4bc5ff6b222469e1d Cr-Commit-Position: refs/heads/master@{#391310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -76 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_network/system_network_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/address_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/ip_address.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/ip_address.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D net/base/ip_address_number.h View 1 chunk +0 lines, -28 lines 0 comments Download
M net/base/ip_endpoint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/ip_endpoint.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/dns/address_sorter_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_test_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/dns/record_rdata.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_socket_address_coder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932363003/1
4 years, 7 months ago (2016-05-01 21:49:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-01 22:58:45 UTC) #6
martijnc
It took a little longer than I expected but net::IPAddressNumber is (almost) gone :) I ...
4 years, 7 months ago (2016-05-02 17:45:32 UTC) #9
eroman
LGTM! Thanks for completing this migration so thoughtfully!
4 years, 7 months ago (2016-05-02 19:42:56 UTC) #10
martijnc
+nparker for the extensions change. +rdevlin.cronin for the safe_browsing change. Can you take a look? ...
4 years, 7 months ago (2016-05-02 21:06:11 UTC) #12
Devlin
On 2016/05/02 21:06:11, martijnc wrote: > +nparker for the extensions change. > +rdevlin.cronin for the ...
4 years, 7 months ago (2016-05-02 21:30:10 UTC) #13
Nathan Parker
lgtm for safe_browsing
4 years, 7 months ago (2016-05-02 21:41:41 UTC) #14
martijnc
On 2016/05/02 at 21:30:10, rdevlin.cronin wrote: > On 2016/05/02 21:06:11, martijnc wrote: > > +nparker ...
4 years, 7 months ago (2016-05-03 17:28:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932363003/1
4 years, 7 months ago (2016-05-03 17:29:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:44:10 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:46:40 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56506d0a3226db78d2a905a4bc5ff6b222469e1d
Cr-Commit-Position: refs/heads/master@{#391310}

Powered by Google App Engine
This is Rietveld 408576698