Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1932193003: [Autofill] Modernize some AutofillMergeTest (Closed)

Created:
4 years, 7 months ago by Mathieu
Modified:
4 years, 7 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Modernize some AutofillMergeTest Slightly change the test runner to create one test case per input file (in line with form_structure_browsertest). As well, change the test cases to work with NAME_FULL and ADDRESS_HOME_STREET_ADDRESS, which reflects the reality and the updated serialize_profiles.py. BUG=None TEST=AutofillMergeTest Committed: https://crrev.com/26b927cd25083ed257d78bf9924ddc1673db701c Cr-Commit-Position: refs/heads/master@{#390879}

Patch Set 1 #

Patch Set 2 : mac import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -91 lines) Patch
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 8 chunks +44 lines, -20 lines 0 comments Download
M components/test/data/autofill/merge/input/ambiguous.in View 1 chunk +4 lines, -3 lines 0 comments Download
M components/test/data/autofill/merge/input/case.in View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/input/email.in View 11 chunks +22 lines, -22 lines 0 comments Download
M components/test/data/autofill/merge/input/identical.in View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/input/primarycase.in View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/input/singlemerge.in View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/input/validation.in View 6 chunks +14 lines, -11 lines 0 comments Download
M components/test/data/autofill/merge/output/case.out View 1 chunk +2 lines, -2 lines 0 comments Download
M components/test/data/autofill/merge/output/email.out View 1 chunk +26 lines, -0 lines 0 comments Download
M components/test/data/autofill/merge/output/identical.out View 1 chunk +2 lines, -2 lines 0 comments Download
M components/test/data/autofill/merge/output/primarycase.out View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/output/singlemerge.out View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test/data/autofill/merge/output/validation.out View 1 chunk +28 lines, -2 lines 0 comments Download
M components/test/data/autofill/merge/tools/autofill_merge_common.py View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Mathieu
Hi Justin, can you have a look? Trying to modernize some tests before we make ...
4 years, 7 months ago (2016-04-29 19:00:42 UTC) #3
Justin Donnelly
lgtm The code all looks good, but I'm not really clear what you're doing here. ...
4 years, 7 months ago (2016-04-29 19:42:49 UTC) #4
Mathieu
Thanks Justin, I updated the description and will attempt to commit if tests pass everywhere ...
4 years, 7 months ago (2016-04-29 19:49:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932193003/20001
4 years, 7 months ago (2016-05-01 21:49:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-01 22:54:17 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:55:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26b927cd25083ed257d78bf9924ddc1673db701c
Cr-Commit-Position: refs/heads/master@{#390879}

Powered by Google App Engine
This is Rietveld 408576698