Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1931233002: Implement PaymentRequestUpdateEvent (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, haraken, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@explicit-shipping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement PaymentRequestUpdateEvent When onShippingAddressChange or onShippingOptionChange event fires, the event type should be PaymentRequestUpdateEvent with an updateWith() method. - The updateWith() method lets the merchant update the shipping options and the total price. - The updateWith() method cannot be called twice for the same event. - The updateWith() method can be called only when the event is being dispatched. - Dispatching a PaymentRequestUpdateEvent created in JavaScript is a no-op. https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-paymentrequestupdateevent BUG=607705 Committed: https://crrev.com/84234b56d641a989f709976793cff331b5488684 Cr-Commit-Position: refs/heads/master@{#392002}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase 1 #

Total comments: 13

Patch Set 3 : Rebase 2 & address comments #

Patch Set 4 : Rebase 3 #

Total comments: 8

Patch Set 5 : Address comments #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -55 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 3 4 2 chunks +46 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/android/payments/payment_request_no_shipping_test.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 5 6 6 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 1 2 3 4 5 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 3 4 5 8 chunks +76 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 1 2 3 4 5 4 chunks +147 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.idl View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventInit.idl View 1 chunk +2 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp View 1 2 3 4 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentUpdater.h View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/ShippingAddress.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 56 (35 generated)
please use gerrit instead
dfalcantara@, ptal chrome/android/. mek@, ptal third_party/WebKit/Source/modules/payments/. Please ignore the trybot failures. This patch has dependencies ...
4 years, 7 months ago (2016-05-02 17:43:00 UTC) #22
please use gerrit instead
palmer@, ptal payment_request.mojom.
4 years, 7 months ago (2016-05-02 17:44:22 UTC) #24
palmer
lgtm
4 years, 7 months ago (2016-05-02 22:37:27 UTC) #25
please use gerrit instead
mek@ and dfalcantara@: I am rebasing on top of the landed patches and applying your ...
4 years, 7 months ago (2016-05-02 23:18:45 UTC) #26
gone
Has the rebase happened yet? Didn't see it uploaded.
4 years, 7 months ago (2016-05-03 05:32:47 UTC) #27
haraken
Binding implementation in modules/ LGTM. https://codereview.chromium.org/1931233002/diff/340001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/1931233002/diff/340001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode401 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:401: m_showResolver.clear(); Don't you want ...
4 years, 7 months ago (2016-05-03 12:34:36 UTC) #29
gone
https://chromiumcodereview.appspot.com/1931233002/diff/360001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java (right): https://chromiumcodereview.appspot.com/1931233002/diff/360001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java#newcode85 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:85: clickPaymentUIView("option line", R.id.payments_selectable_option); Won't this break if you have ...
4 years, 7 months ago (2016-05-03 17:28:20 UTC) #30
Marijn Kruisselbrink
https://chromiumcodereview.appspot.com/1931233002/diff/360001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://chromiumcodereview.appspot.com/1931233002/diff/360001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode368 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:368: ASSERT_UNUSED(success, success); According to the deprecation comments in wtf/Assertions.h ...
4 years, 7 months ago (2016-05-03 17:57:28 UTC) #31
please use gerrit instead
dfalcantara@ & mek@, ptal patch 4. haraken@, see my answer to your question below. https://chromiumcodereview.appspot.com/1931233002/diff/340001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ...
4 years, 7 months ago (2016-05-03 21:38:33 UTC) #33
Marijn Kruisselbrink
https://chromiumcodereview.appspot.com/1931233002/diff/400001/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp File third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp (right): https://chromiumcodereview.appspot.com/1931233002/diff/400001/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp#newcode101 third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp:101: DCHECK(m_updater); This can't just be a DCHECK, you need ...
4 years, 7 months ago (2016-05-03 22:28:51 UTC) #34
gone
java stuff lgtm https://chromiumcodereview.appspot.com/1931233002/diff/360001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java (right): https://chromiumcodereview.appspot.com/1931233002/diff/360001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java#newcode85 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:85: clickPaymentUIView("option line", R.id.payments_selectable_option); On 2016/05/03 21:38:33, ...
4 years, 7 months ago (2016-05-04 02:01:03 UTC) #36
please use gerrit instead
mek@, ptal patch 5. asvitkine@, ptal histograms.xml in patch 5. dfalcantara@, fyi, the integration tests ...
4 years, 7 months ago (2016-05-05 04:57:48 UTC) #39
Marijn Kruisselbrink
lgtm
4 years, 7 months ago (2016-05-05 16:39:30 UTC) #40
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-05 17:27:56 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931233002/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931233002/460001
4 years, 7 months ago (2016-05-05 17:45:09 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/217036)
4 years, 7 months ago (2016-05-05 22:56:30 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931233002/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931233002/460001
4 years, 7 months ago (2016-05-05 23:02:52 UTC) #48
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-06 01:28:06 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931233002/480001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931233002/480001
4 years, 7 months ago (2016-05-06 01:52:11 UTC) #53
commit-bot: I haz the power
Committed patchset #7 (id:480001)
4 years, 7 months ago (2016-05-06 04:23:06 UTC) #54
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 04:25:07 UTC) #56
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/84234b56d641a989f709976793cff331b5488684
Cr-Commit-Position: refs/heads/master@{#392002}

Powered by Google App Engine
This is Rietveld 408576698