Don't include dependent code arrays in snapshots.

Don't include dependent code arrays in snapshots.

Full snapshots never include code that can deopt.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/19956515597c91c543fa1b1f0684218b1d8a2415

[rmacnak, 2016-04-29 00:09:57]

Description was changed from

==========
Don't include dependent code arrays in snapshots.
==========

to

==========
Don't include dependent code arrays in snapshots.

Full snapshots never include code that can deopt.
==========

[rmacnak, 2016-04-29 00:35:55]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-04-29 21:04:24]

LGTM with one comment regarding name of accessors.

https://chromiumcodereview.appspot.com/1930263002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/1930263002/diff/20001/runtime/vm/objec...
runtime/vm/object.h:1389: RawArray* cha_codes() const { return
raw_ptr()->dependent_code_; }
This seems to violate our naming standard that we had which states use lower
case names which match the field name for accessors otherwise use camel case
names.

Why are you not calling the accessor dependent_code() ??

[rmacnak, 2016-04-29 21:47:49]

https://codereview.chromium.org/1930263002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1930263002/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:1389: RawArray* cha_codes() const { return
raw_ptr()->dependent_code_; }
On 2016/04/29 21:04:24, siva wrote:
> This seems to violate our naming standard that we had which states use lower
> case names which match the field name for accessors otherwise use camel case
> names.
> 
> Why are you not calling the accessor dependent_code() ??

Renamed the accessors to [set_]dependent_code and added a comment to match those
on LibraryPrefix and Field.

[rmacnak, 2016-04-29 21:48:16]

Description was changed from

==========
Don't include dependent code arrays in snapshots.

Full snapshots never include code that can deopt.
==========

to

==========
Don't include dependent code arrays in snapshots.

Full snapshots never include code that can deopt.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/19956515597c91c543fa1b1f0684218b1d8a2415
==========

[rmacnak, 2016-04-29 21:48:18]

Committed patchset #3 (id:40001) manually as
19956515597c91c543fa1b1f0684218b1d8a2415 (presubmit successful).