DescriptionMerge 152812 "Breaking whitespace in a white-space:pre-wrap shou..."
> Breaking whitespace in a white-space:pre-wrap should never go on the new line.
>
> This broke in https://src.chromium.org/viewvc/blink?revision=147837&view=revision.
> From that patch, currentCharacterIsWS does not get reset when currentCharacterIsSpace
> does, so previousCharacterIsSpace is now the wrong thing for checking what to do
> with a white-space:pre-wrap space.
>
> Specifically, it's the following line at the end of RenderBlock::LineBreaker::nextSegmentBreak
> where we reset currentCharacterIsSpace, but not currentCharacterShouldCollapseIfPreWap:
> if (!collapseWhiteSpace)
> currentCharacterIsSpace = false;
>
> This code brings that bool back. It's a bit gross, but I couldn't come up with a cleaner
> way to do this. At some point, someone needs to take a hacksaw to
> RenderBlock::LineBreaker::nextSegmentBreak to break it up into digestible pieces.
>
> BUG=246127, 247959
>
> Review URL: https://chromiumcodereview.appspot.com/17434006
TBR=ojan@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154316
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|