Breaking whitespace in a white-space:pre-wrap should never go on the new line.

Breaking whitespace in a white-space:pre-wrap should never go on the new line.

This broke in https://src.chromium.org/viewvc/blink?revision=147837&view=revision.
From that patch, currentCharacterIsWS does not get reset when currentCharacterIsSpace
does, so previousCharacterIsSpace is now the wrong thing for checking what to do
with a white-space:pre-wrap space.

Specifically, it's the following line at the end of RenderBlock::LineBreaker::nextSegmentBreak
where we reset currentCharacterIsSpace, but not currentCharacterShouldCollapseIfPreWap:
        if (!collapseWhiteSpace)
            currentCharacterIsSpace = false;

This code brings that bool back. It's a bit gross, but I couldn't come up with a cleaner
way to do this. At some point, someone needs to take a hacksaw to
RenderBlock::LineBreaker::nextSegmentBreak to break it up into digestible pieces.

BUG=246127, 247959
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152812

[eae, 2013-06-19 04:26:07]

LGTM with caveat.

https://codereview.chromium.org/17434006/diff/1/LayoutTests/fast/text/whitesp...
File
LayoutTests/fast/text/whitespace/pre-wrap-no-space-at-start-of-line-expected.html
(right):

https://codereview.chromium.org/17434006/diff/1/LayoutTests/fast/text/whitesp...
LayoutTests/fast/text/whitespace/pre-wrap-no-space-at-start-of-line-expected.html:4:
<div style="width: 25px; display: inline-block; white-space: pre-wrap; border:
5px solid salmon"><span>foo</span><br><span>bar</span></div>
Using pre-wrap in the expected file seems a bit odd given that a change that
breaks line break for pre-wrap is likely to effect both the test and the
expected results. Could you change this to use white-space: pre instead? Will
render the same.

[commit-bot: I haz the power, 2013-06-20 18:11:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/17434006/5001

[commit-bot: I haz the power, 2013-06-20 19:59:08]

Change committed as 152812