Embed compatibility manifest into all *.exe files

Embed compatibility manifest into all *.exe files

This CL introduces an automated and centralized way to embed
compatibility manifest into all *.exe files. With this CL,
a potential risk of behavioural inconsistency between
production binaries and unit test binaries is resolved by
enforcing the same compatibility context.

This CL uses 'target_conditions' feature of gyp to inject
manifest settings into each executable target. One tricky
part is that some executables such as setup.exe and
mini_installer.exe require external manifest file instead of
embedded one when component build is enabled. 
See http://crbug.com/127233 for this.

You can override the gyp variable
'win_exe_compatibility_manifest' locally for a given
executable target to embed a custom compatibility manifest.

BUG=260692
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214427

[Yohei Yukawa, 2013-07-25 07:13:30]

Hi there.

This is the follow-up CL that I was asked in
https://codereview.chromium.org/18477012/#msg3

Could you take a look?

[tfarina, 2013-07-25 15:03:29]

properly assigning the reviewers list.

[Yohei Yukawa, 2013-07-25 16:21:20]

On 2013/07/25 15:03:29, tfarina wrote:
> properly assigning the reviewers list.

Oh, thank you!

[cpu_(ooo_6.6-7.5), 2013-07-25 19:16:49]

lgtm, 

but I want a second opinion from Scott.

[scottmg, 2013-07-25 19:24:53]

lgtm, but punting again to +alexeypa who is both more familiar and probably more
affected by changes in manifest build.

[grt (UTC plus 2), 2013-07-25 19:40:43]

Recusing myself since, although I like the idea, others on the review list have
more current knowledge in the area than I.

[alexeypa (please no reviews), 2013-07-25 19:46:22]

I am slightly concerned about the same compatibility manifest being injected
into all .EXEs. It would be nice to be able to override the default
compatibility manifest for a given target. 

I'll also going to verify whether this change breaks input injection in
Chromoting on Windows 8. Unfortunately the fasted way to do it is to wait for
the official signed build, so this CL should land first. We need a plan for the
case if it does break Chromoting. 

Other than that - lgtm (including src/remoting).

[Yohei Yukawa, 2013-07-26 01:31:26]

On 2013/07/25 19:46:22, alexeypa wrote:
> I am slightly concerned about the same compatibility manifest being injected
> into all .EXEs. It would be nice to be able to override the default
> compatibility manifest for a given target. 

Ack. I updated the common.gypi as patch set #4 so that a developer can override
the default compatibility manifest for a given target. You can override the
manifest fragment to be embedded by declaring 'win_exe_compatibility_manifest'
locally in a given target.

> I'll also going to verify whether this change breaks input injection in
> Chromoting on Windows 8. Unfortunately the fasted way to do it is to wait for
> the official signed build, so this CL should land first. We need a plan for
the
> case if it does break Chromoting. 

Thanks!

[Yohei Yukawa, 2013-07-26 01:36:36]

+jochen for the OWNER review for
- chrome/tools/crash_service/crash_service.exe.manifest
- content/content_shell.gypi
- content/shell/app/shell.exe.manifest
- ui/views/examples/views_examples.exe.manifest
- ui/views/views.gyp

Could you take a look?

[jochen (gone - plz use gerrit), 2013-07-26 14:57:21]

i don't own all that stuff, but the stuff I own lgtm

[Yohei Yukawa, 2013-07-26 15:22:21]

+sky for the OWNER review of
- ui/views/examples/views_examples.exe.manifest
- ui/views/views.gyp

Could you take a look?

[alexeypa (please no reviews), 2013-07-26 15:52:48]

On 2013/07/26 01:31:26, Yohei Yukawa wrote:
> Ack. I updated the common.gypi as patch set #4 so that a developer can
override
> the default compatibility manifest for a given target. You can override the
> manifest fragment to be embedded by declaring 'win_exe_compatibility_manifest'
> locally in a given target.

Thanks. lgtm.

[sky, 2013-07-26 19:09:38]

LGTM

[commit-bot: I haz the power, 2013-07-27 20:45:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/19275010/68001

[commit-bot: I haz the power, 2013-07-28 00:11:15]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Yohei Yukawa, 2013-07-28 04:27:47]

On 2013/07/25 19:40:43, grt wrote:
> Recusing myself since, although I like the idea, others on the review list
have
> more current knowledge in the area than I.

Hi Greg, could you take a look at the following file as OWNER review?
- chrome_frame/chrome_frame.gyp

Thanks!

[grt (UTC plus 2), 2013-07-29 15:56:05]

lgtm

[commit-bot: I haz the power, 2013-07-29 15:59:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/19275010/68001

[commit-bot: I haz the power, 2013-07-30 00:31:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/19275010/68001

[commit-bot: I haz the power, 2013-07-30 10:34:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Yukawa@chromium.org/19275010/68001

[commit-bot: I haz the power, 2013-07-30 20:24:53]

Change committed as 214427

[alexeypa (please no reviews), 2013-08-05 19:42:44]

On 2013/07/25 19:46:22, alexeypa wrote:
> I'll also going to verify whether this change breaks input injection in
> Chromoting on Windows 8. Unfortunately the fasted way to do it is to wait for
> the official signed build, so this CL should land first. We need a plan for
the
> case if it does break Chromoting. 

FYI. I just verified this CL on Win8. Chromoting works, so I think we are good.