chrome/chrome_exe.gypi - Issue 19275010: Embed compatibility manifest into all *.exe files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_exe.gypi

Issue 19275010: Embed compatibility manifest into all *.exe files (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: style fix Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_exe.gypi

diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi

index 96be31f916a925646e575b53e8d7d32b6448a9c7..75adb4e7f9466dfd82b511be810d7bbd55660fc1 100644

--- a/chrome/chrome_exe.gypi

+++ b/chrome/chrome_exe.gypi

@@ -45,10 +45,8 @@

'conditions': [

['component == "shared_library"', {

- 'msvs_settings': {

- 'VCManifestTool': {

- 'EmbedManifest': 'false',

- },

+ 'variables': {

+ 'win_use_external_manifest': 1,

}],

['order_profiling!=0 and (chromeos==1 or OS=="linux")', {

@@ -499,7 +497,9 @@

'SubSystem': '2',

'VCManifestTool': {

- 'AdditionalManifestFiles': '$(ProjectDir)\\app\\chrome.exe.manifest',

+ 'AdditionalManifestFiles': [

+ '$(ProjectDir)\\app\\chrome.exe.manifest',

+ ],

'actions': [

« no previous file with comments | « chrome/chrome_dll.gypi ('k') | chrome/chrome_installer.gypi » ('j') | no next file with comments »