Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 192743007: Use the default dispatcher where possible for nested message loops. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by sadrul
Modified:
1 year, 3 months ago
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Use the default dispatcher where possible for nested message loops. Notable changes: * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to terminate a nested loop started by RunWithDispatcher(). * FirstRunDialog is no longer a MessagePumpDispatcher. The default dispatcher is used instead, and QuitNestedMessageLoop() is called to terminate the loop instead of returning POST_DISPATCH_QUIT_LOOP from the Dispatch() override. This change was previously committed in r253723 and r254089, but reverted in r253744 and r254095 because some interactive_ui_tests on windows bots failed on SimpleMessageBoxViews related change. So this CL aims to reland that CL without the change in SimpleMessageBoxViews for now. BUG=342338 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256093

Patch Set 1 #

Patch Set 2 : Revert change in SimpleMessageBoxViews. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.h View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M ui/aura/client/dispatcher_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
sadrul
Hi! This is an attempt to reland the changes in https://codereview.chromium.org/182143002/, without the change in ...
1 year, 3 months ago (2014-03-10 21:11:57 UTC) #1
sky (OOO until 7-20)
LGTM
1 year, 3 months ago (2014-03-10 22:43:10 UTC) #2
sadrul
1 year, 3 months ago (2014-03-11 01:19:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r256093 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d