Issue 19267019: Try to remove invalidated stubs before falling back to checking the constant state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19267019: Try to remove invalidated stubs before falling back to checking the constant state. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
Hannes Payer (out of office), danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Try to remove invalidated stubs before falling back to checking the constant state. BUG=chromium:260585 R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15693

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -20 lines)			Patch
	M	src/ic.cc	View	1	2 chunks	+23 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, one nit https://chromiumcodereview.appspot.com/19267019/diff/1/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/19267019/diff/1/src/ic.cc#newcode235 src/ic.cc:235: // the map cannot be deprecated ...

7 years, 5 months ago (2013-07-16 13:55:37 UTC) #2

Toon Verwaest

7 years, 5 months ago (2013-07-16 14:01:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15693 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19267019: Try to remove invalidated stubs before falling back to checking the constant state. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages