Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/ic.cc

Issue 19267019: Try to remove invalidated stubs before falling back to checking the constant state. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 2f63feefd9750beb2f3cc833a96c1300f0baa3ff..e09d83e6fa1ac11541abfc81d693ddbede786758 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -191,17 +191,6 @@ static bool TryRemoveInvalidPrototypeDependentStub(Code* target,
if (Name::cast(name) != stub_name) return false;
}
- if (receiver->IsGlobalObject()) {
- if (!name->IsName()) return false;
- Isolate* isolate = target->GetIsolate();
- LookupResult lookup(isolate);
- GlobalObject* global = GlobalObject::cast(receiver);
- global->LocalLookupRealNamedProperty(Name::cast(name), &lookup);
- if (!lookup.IsFound()) return false;
- PropertyCell* cell = global->GetPropertyCell(&lookup);
- return cell->type()->IsConstant();
- }
-
InlineCacheHolderFlag cache_holder =
Code::ExtractCacheHolderFromFlags(target->flags());
@@ -242,18 +231,32 @@ static bool TryRemoveInvalidPrototypeDependentStub(Code* target,
return true;
}
+ // The stub is not in the cache. We've ruled out all other kinds of failure
+ // except for proptotype chain changes, a deprecated map, a map that's
+ // different from the one that the stub expects, or a constant global property
+ // that will become mutable. Threat all those situations as prototype failures
+ // (stay monomorphic if possible).
+
// If the IC is shared between multiple receivers (slow dictionary mode), then
// the map cannot be deprecated and the stub invalidated.
- if (cache_holder != OWN_MAP) return false;
+ if (cache_holder == OWN_MAP) {
+ Map* old_map = target->FindFirstMap();
+ if (old_map == map) return true;
+ if (old_map != NULL && old_map->is_deprecated()) return true;
+ }
- // The stub is not in the cache. We've ruled out all other kinds of failure
- // except for proptotype chain changes, a deprecated map, or a map that's
- // different from the one that the stub expects. If the map hasn't changed,
- // assume it's a prototype failure. Treat deprecated maps in the same way as
- // prototype failures (stay monomorphic if possible).
- Map* old_map = target->FindFirstMap();
- if (old_map == NULL) return false;
- return old_map == map || old_map->is_deprecated();
+ if (receiver->IsGlobalObject()) {
+ if (!name->IsName()) return false;
+ Isolate* isolate = target->GetIsolate();
+ LookupResult lookup(isolate);
+ GlobalObject* global = GlobalObject::cast(receiver);
+ global->LocalLookupRealNamedProperty(Name::cast(name), &lookup);
+ if (!lookup.IsFound()) return false;
+ PropertyCell* cell = global->GetPropertyCell(&lookup);
+ return cell->type()->IsConstant();
+ }
+
+ return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698