Don't hide the reparenting tab while detaching

Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force capturing a thumbnail which is causing another crash.

BUG=605757, 603323
Committed: https://crrev.com/6060790e2827d922b3c3b6c1645344aec21d57c6
Cr-Commit-Position: refs/heads/master@{#389931}

[Yusuf, 2016-04-26 17:11:04]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 17:11:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924473002/1

[Yusuf, 2016-04-26 17:17:51]

Description was changed from

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding leaves the tab in a weird state on the native side even if
show is called from the java side later on and should also be avoided
for UX purposes.

BUG=605757
==========

to

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding leaves the tab in a weird state on the native side even if
show is called from the java side later on and should also be avoided
for UX purposes.

BUG=605757, 603323
==========

[Yusuf, 2016-04-26 17:43:51]

Description was changed from

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding leaves the tab in a weird state on the native side even if
show is called from the java side later on and should also be avoided
for UX purposes.

BUG=605757, 603323
==========

to

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side
even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force
capturing a thumbnail which is causing another crash.

BUG=605757, 603323
==========

[commit-bot: I haz the power, 2016-04-26 18:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:10:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2016-04-26 18:47:01]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-04-26 22:05:38]

lgtm

https://codereview.chromium.org/1924473002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/1924473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:1492:
mDetachedForReparenting = false;
nit: mIsDetachedForReparenting

https://codereview.chromium.org/1924473002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
(right):

https://codereview.chromium.org/1924473002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:1233:
tabToBeReparented.addObserver(new EmptyTabObserver() {
This Observer should probably be removed at some point.

[Yusuf, 2016-04-26 22:09:34]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-04-26 22:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1924473002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-04-26 22:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924473002/20001

[Yusuf, 2016-04-26 22:10:15]

https://codereview.chromium.org/1924473002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right):

https://codereview.chromium.org/1924473002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:1492:
mDetachedForReparenting = false;
On 2016/04/26 22:05:38, dfalcantara wrote:
> nit: mIsDetachedForReparenting

Done.

https://codereview.chromium.org/1924473002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
(right):

https://codereview.chromium.org/1924473002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:1233:
tabToBeReparented.addObserver(new EmptyTabObserver() {
On 2016/04/26 22:05:38, dfalcantara wrote:
> This Observer should probably be removed at some point.

Done.

[commit-bot: I haz the power, 2016-04-26 22:45:46]

Description was changed from

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side
even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force
capturing a thumbnail which is causing another crash.

BUG=605757, 603323
==========

to

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side
even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force
capturing a thumbnail which is causing another crash.

BUG=605757, 603323
==========

[commit-bot: I haz the power, 2016-04-26 22:45:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 22:47:44]

Description was changed from

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side
even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force
capturing a thumbnail which is causing another crash.

BUG=605757, 603323
==========

to

==========
Don't hide the reparenting tab while detaching

During the "move to other window" changes to removeTab, we have
started hiding the visible tab in custom tab as a byproduct of setIndex.
Hiding during reparenting leaves the tab in a weird state on the native side
even if
show is called from the java side later on and should also be avoided
for UX purposes. Another thing happening in the same if clause is force
capturing a thumbnail which is causing another crash.

BUG=605757, 603323

Committed: https://crrev.com/6060790e2827d922b3c3b6c1645344aec21d57c6
Cr-Commit-Position: refs/heads/master@{#389931}
==========

[commit-bot: I haz the power, 2016-04-26 22:47:45]

Patchset 2 (id:??) landed as
https://crrev.com/6060790e2827d922b3c3b6c1645344aec21d57c6
Cr-Commit-Position: refs/heads/master@{#389931}