Issue 19235003: Fix dart:js test for IE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19235003: Fix dart:js test for IE (Closed)

Created:
7 years, 5 months ago by vsm

Modified:
7 years, 5 months ago

Reviewers:
alexandre.ardhuin, justinfagnani, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart:js test for IE R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=25038

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/html/js_test.dart	View		3 chunks	+11 lines, -9 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

This gets js_test passing on IE9 for me. https://chromiumcodereview.appspot.com/19235003/diff/1/tests/html/js_test.dart File tests/html/js_test.dart (right): https://chromiumcodereview.appspot.com/19235003/diff/1/tests/html/js_test.dart#newcode94 tests/html/js_test.dart:94: for ...

7 years, 5 months ago (2013-07-15 22:42:21 UTC) #1

vsm

Committed patchset #1 manually as r25038 (presubmit successful).

7 years, 5 months ago (2013-07-16 00:02:57 UTC) #3

kustermann

7 years, 5 months ago (2013-07-16 11:21:58 UTC) #5

Message was sent while issue was closed.

html/js_test is still failing. See for example:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ie9-win7-all-4...

Expand Messages | Collapse Messages