Issue 19232002: Do not modify document in StyleResolverState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19232002: Do not modify document in StyleResolverState (Closed)

Created:
7 years, 5 months ago by eae

Modified:
7 years, 5 months ago

Reviewers:
dglazkov, eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Do not modify document in StyleResolverState Change StyleResolverState::initForStyleResolve to take a const Document pointer and move code that modifies the document to StyleResolver. BUG=260293 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154242

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -11 lines)			Patch
M	Source/core/css/resolver/StyleResolver.cpp	View	6 chunks	+17 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.cpp	View	3 chunks	+2 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/19232002/1

7 years, 5 months ago (2013-07-15 17:17:10 UTC) #3

Message was sent while issue was closed.

Change committed as 154242