Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: impl/memory/datastore_query_execution_test.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/memory/datastore.go ('k') | impl/memory/datastore_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/memory/datastore_query_execution_test.go
diff --git a/impl/memory/datastore_query_execution_test.go b/impl/memory/datastore_query_execution_test.go
index 41f4a898b2356b8466cb60cbffd3699ff14d83cc..3a57b07c4bcb987913287609b9828cbe59d45265 100644
--- a/impl/memory/datastore_query_execution_test.go
+++ b/impl/memory/datastore_query_execution_test.go
@@ -85,7 +85,7 @@ var stage2Data = []ds.PropertyMap{
"Val", 3, 4, 2, 1, Next,
"Extra", "nuts",
),
- pmap("$key", ds.MakeKey("dev~app", "", "Kind", "id")),
+ pmap("$key", ds.MakeKey("dev~app", "jim", "Kind", "id")),
iannucci 2016/04/22 19:13:49 s/jim/kat
pmap("$key", ds.MakeKey("dev~app", "bob", "Kind", "id")),
}
@@ -351,16 +351,16 @@ var queryExecutionTests = []qExTest{
stage1Data[2],
}},
{q: nq("__namespace__"), get: []ds.PropertyMap{
- pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", 1)),
pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),
iannucci 2016/04/22 19:13:49 lost test for default namespace :/. Could we add a
+ pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "ns")),
}},
{q: nq("__namespace__").Offset(1), get: []ds.PropertyMap{
- pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),
+ pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "ns")),
}},
{q: nq("__namespace__").Offset(1).Limit(1), get: []ds.PropertyMap{
- pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),
+ pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
}},
},
« no previous file with comments | « impl/memory/datastore.go ('k') | impl/memory/datastore_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698