impl/memory: Disallow empty namespace.

impl/memory/datastore_query_execution_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "fmt"
         "strings"
         "testing"
@@ skipping 67 matching lines @@
                 "Extra", "hello", "waffle",
         ),
         pmap("$key", key("Kind", 3, "Kind", 2), Next,
                 "Val", 3, 4, Next,
                 "Extra", "hello", "waffle",
         ),
         pmap("$key", key("Kind", 3, "Kind", 3), Next,
                 "Val", 3, 4, 2, 1, Next,
                 "Extra", "nuts",
         ),
-        pmap("$key", ds.MakeKey("dev~app", "", "Kind", "id")),
+        pmap("$key", ds.MakeKey("dev~app", "jim", "Kind", "id")),

[iannucci, 2016/04/22 19:13:49]

s/jim/kat

         pmap("$key", ds.MakeKey("dev~app", "bob", "Kind", "id")),
 }
 
 var collapsedData = []ds.PropertyMap{
         // PTTime
         pmap("$key", key("Kind", 1), Next,
                 "Date", time.Date(2000, time.January, 1, 1, 1, 1, 1, time.UTC), Next,
         ),
         pmap("$key", key("Kind", 2), Next,
                 "Date", time.Date(2000, time.March, 1, 1, 1, 1, 1, time.UTC), Next,
@@ skipping 245 matching lines @@
                                                 "When", 996688461000000),
                                 }},
 
                                 // Original (complex) types are retained when getting the full value.
                                 {q: nq("Kind").Order("When"), get: []ds.PropertyMap{
                                         stage1Data[1],
                                         stage1Data[3],
                                         stage1Data[2],
                                 }},
                                 {q: nq("__namespace__"), get: []ds.PropertyMap{
-                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", 1)),
                                         pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),

[iannucci, 2016/04/22 19:13:49]

lost test for default namespace :/. Could we add a quick ad-hoc one?

+                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
                                         pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "ns")),
                                 }},
                                 {q: nq("__namespace__").Offset(1), get: []ds.PropertyMap{
-                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),
+                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
                                         pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "ns")),
                                 }},
                                 {q: nq("__namespace__").Offset(1).Limit(1), get: []ds.PropertyMap{
-                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "bob")),
+                                        pmap("$key", ds.MakeKey("dev~app", "", "__namespace__", "jim")),
                                 }},
                         },
 
                         extraFns: []func(context.Context){
                                 func(c context.Context) {
                                         data := ds.Get(c)
                                         curs := ds.Cursor(nil)
 
                                         q := nq("").Gt("__key__", key("Kind", 2))
 
@@ skipping 263 matching lines @@
 
         v, ok := actual.(error)
         if !ok {
                 return fmt.Sprintf("type of 'actual' must be error, not %T", actual)
         }
         if v == nil || v == ds.Stop {
                 return ""
         }
         return fmt.Sprintf("expected success value, not %v", v)
 }