Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Issue 19117005: IndexedDB: Coding conventions and cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
index 9c21b9afcc39b77f5b0f755f0f9b9c6a1db6b2e1..1633ce3d5e1815443bb4fe5422def6b075117cd7 100644
--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
@@ -321,10 +321,6 @@ TEST_F(IndexedDBBackingStoreTest, CreateDatabase) {
class MockIDBFactory : public IndexedDBFactory {
public:
- static scoped_refptr<MockIDBFactory> Create() {
- return make_scoped_refptr(new MockIDBFactory());
- }
-
scoped_refptr<IndexedDBBackingStore> TestOpenBackingStore(
const GURL& origin,
const base::FilePath& data_directory) {
@@ -346,7 +342,7 @@ TEST(IndexedDBFactoryTest, BackingStoreLifetime) {
GURL origin1("http://localhost:81");
GURL origin2("http://localhost:82");
- scoped_refptr<MockIDBFactory> factory = MockIDBFactory::Create();
+ scoped_refptr<MockIDBFactory> factory = new MockIDBFactory();
base::ScopedTempDir temp_directory;
ASSERT_TRUE(temp_directory.CreateUniqueTempDir());
@@ -372,7 +368,7 @@ TEST(IndexedDBFactoryTest, MemoryBackingStoreLifetime) {
GURL origin1("http://localhost:81");
GURL origin2("http://localhost:82");
- scoped_refptr<MockIDBFactory> factory = MockIDBFactory::Create();
+ scoped_refptr<MockIDBFactory> factory = new MockIDBFactory();
scoped_refptr<IndexedDBBackingStore> mem_store1 =
factory->TestOpenBackingStore(origin1, base::FilePath());
EXPECT_FALSE(mem_store1->HasOneRef()); // mem_store1 and factory
@@ -401,7 +397,7 @@ TEST(IndexedDBFactoryTest, RejectLongOrigins) {
base::ScopedTempDir temp_directory;
ASSERT_TRUE(temp_directory.CreateUniqueTempDir());
const base::FilePath base_path = temp_directory.path();
- scoped_refptr<MockIDBFactory> factory = MockIDBFactory::Create();
+ scoped_refptr<MockIDBFactory> factory = new MockIDBFactory();
int limit = file_util::GetMaximumPathComponentLength(base_path);
EXPECT_GT(limit, 0);

Powered by Google App Engine
This is Rietveld 408576698