Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: content/browser/indexed_db/indexed_db_callbacks.h

Issue 19117005: IndexedDB: Coding conventions and cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_callbacks.h
diff --git a/content/browser/indexed_db/indexed_db_callbacks.h b/content/browser/indexed_db/indexed_db_callbacks.h
index c9e5e0fb3d1363970ab956837ca2ed4b9813b366..8ab8ae40aaf059c388d59e6edd83cb7edba599b6 100644
--- a/content/browser/indexed_db/indexed_db_callbacks.h
+++ b/content/browser/indexed_db/indexed_db_callbacks.h
@@ -31,38 +31,23 @@ class CONTENT_EXPORT IndexedDBCallbacks
: public base::RefCounted<IndexedDBCallbacks> {
public:
// Simple payload responses
- static scoped_refptr<IndexedDBCallbacks> Create(
- IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id) {
- return make_scoped_refptr(new IndexedDBCallbacks(
- dispatcher_host, ipc_thread_id, ipc_callbacks_id));
- }
+ IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+ int32 ipc_thread_id,
+ int32 ipc_callbacks_id);
// IndexedDBCursor responses
- static scoped_refptr<IndexedDBCallbacks> Create(
- IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id,
- int32 ipc_cursor_id) {
- return make_scoped_refptr(new IndexedDBCallbacks(
- dispatcher_host, ipc_thread_id, ipc_callbacks_id, ipc_cursor_id));
- }
+ IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+ int32 ipc_thread_id,
+ int32 ipc_callbacks_id,
+ int32 ipc_cursor_id);
+
// IndexedDBDatabase responses
- static scoped_refptr<IndexedDBCallbacks> Create(
- IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id,
- int32 ipc_database_callbacks_id,
- int64 host_transaction_id,
- const GURL& origin_url) {
- return make_scoped_refptr(new IndexedDBCallbacks(dispatcher_host,
- ipc_thread_id,
- ipc_callbacks_id,
- ipc_database_callbacks_id,
- host_transaction_id,
- origin_url));
- }
+ IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+ int32 ipc_thread_id,
+ int32 ipc_callbacks_id,
+ int32 ipc_database_callbacks_id,
+ int64 host_transaction_id,
+ const GURL& origin_url);
virtual void OnError(const IndexedDBDatabaseError& error);
@@ -119,25 +104,6 @@ class CONTENT_EXPORT IndexedDBCallbacks
protected:
virtual ~IndexedDBCallbacks();
- // Simple payload responses
- IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id);
-
- // IndexedDBCursor responses
- IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id,
- int32 ipc_cursor_id);
-
- // IndexedDBDatabase responses
- IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
- int32 ipc_thread_id,
- int32 ipc_callbacks_id,
- int32 ipc_database_callbacks_id,
- int64 host_transaction_id,
- const GURL& origin_url);
-
private:
friend class base::RefCounted<IndexedDBCallbacks>;

Powered by Google App Engine
This is Rietveld 408576698