chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java - Issue 1909763002: Add callout for the tab switcher button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

Issue 1909763002: Add callout for the tab switcher button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/anim/text_bubble_out.xml ('K') | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

index fddb546461e5e8e9860cfbc32505d60b89963899..6005e14446b7d73d6169150d1dd7a3653d9d3657 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

@@ -33,6 +33,7 @@ import org.chromium.chrome.browser.tabmodel.document.ActivityDelegateImpl;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModel;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelImpl;

import org.chromium.chrome.browser.tabmodel.document.StorageDelegate;

+import org.chromium.chrome.browser.toolbar.TabSwitcherCallout;

import org.chromium.chrome.browser.util.FeatureUtilities;

import java.io.File;

@@ -366,6 +367,7 @@ public class DocumentModeAssassin {

Log.d(TAG, "Setting tabbed mode preference.");

DocumentModeManager.getInstance(getContext()).setOptedOutState(

DocumentModeManager.OPTED_OUT_OF_DOCUMENT_MODE);

+ TabSwitcherCallout.setIsTabSwitcherCalloutNecessary(getContext(), true);

// Remove all the {@link DocumentActivity} tasks from Android's Recents list. Users

// viewing Recents during migration will continue to see their tabs until they exit.