Add callout for the tab switcher button

Add callout for the tab switcher button

* Gut the TextBubble class so that it only points upward.
  Give it the ability to display more than just a TextView.

* Restyle the bubble using jerry-rigged existing assets
  because the popup is temporary anyway.

* Make the DocumentModeAssassin record that the callout
  needs to be displayed.

- Doesn't hook it in yet because the logic is being hashed out.

BUG=582539, 593138
Committed: https://crrev.com/b56a67064670ef6c4b432191c21461a4f50d2557
Cr-Commit-Position: refs/heads/master@{#388997}

[gone, 2016-04-21 00:49:04]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2016-04-21 00:49:04]

Logic to show the callout is still being worked on.

[Ted C, 2016-04-21 16:31:48]

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
File chrome/android/java/res/anim/text_bubble_in.xml (right):

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
chrome/android/java/res/anim/text_bubble_in.xml:2: <!-- Copyright (c) 2016 The
Chromium Authors. All rights reserved.
no (c)

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
chrome/android/java/res/anim/text_bubble_in.xml:9:
android:interpolator="@android:interpolator/fast_out_slow_in" >
this looks like it only exists in api 21+

http://developer.android.com/reference/android/R.interpolator.html#fast_out_s...

is it added via the support library before that?

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
chrome/android/java/res/anim/text_bubble_in.xml:16: android:fromYDelta="-10"
by default is this px or dp?

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
File chrome/android/java/res/anim/text_bubble_out.xml (right):

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/res/ani...
chrome/android/java/res/anim/text_bubble_out.xml:2: <!-- Copyright (c) 2016 The
Chromium Authors. All rights reserved.
same general comments

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java
(right):

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java:90:
super(context, 0.33f);
Y_OVERLAP_PERCENTAGE?

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/widget/TextBubble.java
(right):

https://codereview.chromium.org/1909763002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/TextBubble.java:240:
Math.max(padding.top, mBubbleArrowDrawable.getIntrinsicHeight()),
should be 8 from the start of the row

[gone, 2016-04-21 21:18:26]

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
File chrome/android/java/res/anim/text_bubble_in.xml (right):

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/res/anim/text_bubble_in.xml:2: <!-- Copyright (c) 2016 The
Chromium Authors. All rights reserved.
On 2016/04/21 16:31:48, Ted C wrote:
> no (c)

Done.

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/res/anim/text_bubble_in.xml:9:
android:interpolator="@android:interpolator/fast_out_slow_in" >
On 2016/04/21 16:31:48, Ted C wrote:
> this looks like it only exists in api 21+
> 
>
http://developer.android.com/reference/android/R.interpolator.html#fast_out_s...
> 
> is it added via the support library before that?

Yes, but there's no obvious way to trigger it.  Reached out to
android-chatty-eng, but the (currently only) person who responded said it wasn't
possible.  Made it so that the bubble could only appear for SDK level 21 and
above as a concession.

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/res/anim/text_bubble_in.xml:16: android:fromYDelta="-10"
On 2016/04/21 16:31:48, Ted C wrote:
> by default is this px or dp?

px; apparently you can't define DP for animations:

http://developer.android.com/guide/topics/resources/animation-resource.html

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
File chrome/android/java/res/anim/text_bubble_out.xml (right):

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/res/anim/text_bubble_out.xml:2: <!-- Copyright (c) 2016 The
Chromium Authors. All rights reserved.
On 2016/04/21 16:31:48, Ted C wrote:
> same general comments

Done.

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java
(right):

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java:90:
super(context, 0.33f);
On 2016/04/21 16:31:48, Ted C wrote:
> Y_OVERLAP_PERCENTAGE?

Knew there was a reason that I added that constant.  Got halfway there.

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/widget/TextBubble.java
(right):

https://chromiumcodereview.appspot.com/1909763002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/widget/TextBubble.java:240:
Math.max(padding.top, mBubbleArrowDrawable.getIntrinsicHeight()),
On 2016/04/21 16:31:48, Ted C wrote:
> should be 8 from the start of the row

Done.

[Ted C, 2016-04-21 22:57:22]

lgtm

[gone, 2016-04-22 00:44:22]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:44:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909763002/60001

[commit-bot: I haz the power, 2016-04-22 01:53:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:43:17]

Description was changed from

==========
Add callout for the tab switcher button

* Gut the TextBubble class so that it only points upward.
  Give it the ability to display more than just a TextView.

* Restyle the bubble using jerry-rigged existing assets
  because the popup is temporary anyway.

* Make the DocumentModeAssassin record that the callout
  needs to be displayed.

- Doesn't hook it in yet because the logic is being hashed out.

BUG=582539,593138
==========

to

==========
Add callout for the tab switcher button

* Gut the TextBubble class so that it only points upward.
  Give it the ability to display more than just a TextView.

* Restyle the bubble using jerry-rigged existing assets
  because the popup is temporary anyway.

* Make the DocumentModeAssassin record that the callout
  needs to be displayed.

- Doesn't hook it in yet because the logic is being hashed out.

BUG=582539,593138

Committed: https://crrev.com/b56a67064670ef6c4b432191c21461a4f50d2557
Cr-Commit-Position: refs/heads/master@{#388997}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:18]

Patchset 4 (id:??) landed as
https://crrev.com/b56a67064670ef6c4b432191c21461a4f50d2557
Cr-Commit-Position: refs/heads/master@{#388997}