Issue 19059004: Remove didReceiveDocumentData() and set its only state in didCommitProvisionalLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19059004: Remove didReceiveDocumentData() and set its only state in didCommitProvisionalLoad (Closed)

Created:
7 years, 5 months ago by Nate Chapin

Modified:
7 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove didReceiveDocumentData() and set its only state in didCommitProvisionalLoad The only use for this callback is to set state that we could just as well set in didCommitProvisionalLoad, which is called almost immediately after. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212390

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -22 lines)			Patch
M	content/renderer/render_frame_impl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/19059004/1

7 years, 5 months ago (2013-07-18 15:52:33 UTC) #3

Message was sent while issue was closed.

Change committed as 212390

Expand Messages | Collapse Messages