Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/renderer/render_view_impl.cc

Issue 19059004: Remove didReceiveDocumentData() and set its only state in didCommitProvisionalLoad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 7049cd269232adcd65df694ef796e65d3d77bab4..5902d11d16d6c9b287f2512b11cde84818594d6d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3732,14 +3732,6 @@ void RenderViewImpl::didFailProvisionalLoad(WebFrame* frame,
LoadNavigationErrorPage(frame, failed_request, error, std::string(), replace);
}
-void RenderViewImpl::didReceiveDocumentData(
- WebFrame* frame, const char* data, size_t data_len,
- bool& prevent_default) {
- InternalDocumentStateData* internal_data =
- InternalDocumentStateData::FromDataSource(frame->dataSource());
- internal_data->set_use_error_page(false);
-}
-
void RenderViewImpl::didCommitProvisionalLoad(WebFrame* frame,
bool is_new_navigation) {
DocumentState* document_state =
@@ -3755,6 +3747,7 @@ void RenderViewImpl::didCommitProvisionalLoad(WebFrame* frame,
webview()->resetScrollAndScaleState();
internal_data->set_must_reset_scroll_and_scale_state(false);
}
+ internal_data->set_use_error_page(false);
if (is_new_navigation) {
// When we perform a new navigation, we need to update the last committed
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698