Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19010006: core/dom: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, chromiumbugtracker_adobe.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

core/dom: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' Source/core/dom | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' BUG=254653 R=abarth@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154084

Patch Set 1 #

Patch Set 2 : two fixes #

Total comments: 2

Patch Set 3 : rm extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -196 lines) Patch
M Source/core/dom/ActiveDOMObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/CharacterData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CheckedRadioButtons.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/CheckedRadioButtons.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildListMutationScope.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/ChildNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/CrossThreadTask.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DOMError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMNamedFlowCollection.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMStringList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMStringMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DeviceOrientationData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarker.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentSharedObjectPool.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ErrorEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Event.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/EventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventDispatchMediator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventListenerMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventNames.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventQueue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventRetargeter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventSender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExceptionCodePlaceholder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/GenericEventQueue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/GestureEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationCallback.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/MutationObserverRegistration.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/NameNodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedFlowCollection.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/NamedFlowCollection.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/NamedNodeMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/NodeFilterCondition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/PendingScript.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Position.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/QualifiedName.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/QualifiedName.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/RegisteredEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RequestAnimationFrameCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScopedEventQueue.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ScopedEventQueue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptableDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SecurityContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/SecurityContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/SpaceSplitString.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/StaticNodeList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/StringCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StringCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TagNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TagNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TransformSource.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Traversal.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeWalker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UserGestureIndicator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/UserTypingGestureIndicator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/UserTypingGestureIndicator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ViewportArguments.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/WebCoreMemoryInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/WindowEventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/default/PlatformMessagePortChannel.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/default/chromium/PlatformMessagePortChannelChromium.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years, 5 months ago (2013-07-12 00:22:29 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/19010006/diff/3001/Source/core/dom/ChildListMutationScope.cpp File Source/core/dom/ChildListMutationScope.cpp (right): https://codereview.chromium.org/19010006/diff/3001/Source/core/dom/ChildListMutationScope.cpp#newcode32 Source/core/dom/ChildListMutationScope.cpp:32: extra blank line here
7 years, 5 months ago (2013-07-12 00:34:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/19010006/7001
7 years, 5 months ago (2013-07-12 01:10:45 UTC) #3
tfarina
https://codereview.chromium.org/19010006/diff/3001/Source/core/dom/ChildListMutationScope.cpp File Source/core/dom/ChildListMutationScope.cpp (right): https://codereview.chromium.org/19010006/diff/3001/Source/core/dom/ChildListMutationScope.cpp#newcode32 Source/core/dom/ChildListMutationScope.cpp:32: On 2013/07/12 00:34:02, abarth wrote: > extra blank line ...
7 years, 5 months ago (2013-07-12 01:11:00 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 05:21:41 UTC) #5
Message was sent while issue was closed. 
Change committed as 154084

Powered by Google App Engine
This is Rietveld 408576698