Source/core/rendering/RenderFlexibleBox.h - Issue 18978010: Setting up OrderIterator shouldn't require an extra Vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 18978010: Setting up OrderIterator shouldn't require an extra Vector (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated after cbiesinger's review Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlexibleBox.h

diff --git a/Source/core/rendering/RenderFlexibleBox.h b/Source/core/rendering/RenderFlexibleBox.h

index 415d4494eac859d47b0826b45038d249a0866056..3d5fc26aa9393765f4a5414ab42897d9f103135b 100644

--- a/Source/core/rendering/RenderFlexibleBox.h

+++ b/Source/core/rendering/RenderFlexibleBox.h

@@ -135,7 +135,7 @@ private:

LayoutUnit marginBoxAscentForChild(RenderBox*);

LayoutUnit computeChildMarginValue(Length margin, RenderView*);

- void computeMainAxisPreferredSizes(Vector<int>&);

+ void prepareOrderIteratorAndMargins();

LayoutUnit adjustChildSizeForMinAndMax(RenderBox*, LayoutUnit childSize);

// The hypothetical main size of an item is the flex base size clamped according to its min and max main size properties

bool computeNextFlexLine(OrderedFlexItemList& orderedChildren, LayoutUnit& sumFlexBaseSize, double& totalFlexGrow, double& totalWeightedFlexShrink, LayoutUnit& sumHypotheticalMainSize, bool& hasInfiniteLineLength);

« no previous file with comments | « Source/core/rendering/OrderIterator.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »