Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 18978010: Setting up OrderIterator shouldn't require an extra Vector (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after cbiesinger's review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/OrderIterator.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 bool updateAutoMarginsInCrossAxis(RenderBox* child, LayoutUnit availableAlig nmentSpace); 128 bool updateAutoMarginsInCrossAxis(RenderBox* child, LayoutUnit availableAlig nmentSpace);
129 void repositionLogicalHeightDependentFlexItems(Vector<LineContext>&); 129 void repositionLogicalHeightDependentFlexItems(Vector<LineContext>&);
130 LayoutUnit clientLogicalBottomAfterRepositioning(); 130 LayoutUnit clientLogicalBottomAfterRepositioning();
131 void appendChildFrameRects(ChildFrameRects&); 131 void appendChildFrameRects(ChildFrameRects&);
132 void repaintChildrenDuringLayoutIfMoved(const ChildFrameRects&); 132 void repaintChildrenDuringLayoutIfMoved(const ChildFrameRects&);
133 133
134 LayoutUnit availableAlignmentSpaceForChild(LayoutUnit lineCrossAxisExtent, R enderBox*); 134 LayoutUnit availableAlignmentSpaceForChild(LayoutUnit lineCrossAxisExtent, R enderBox*);
135 LayoutUnit marginBoxAscentForChild(RenderBox*); 135 LayoutUnit marginBoxAscentForChild(RenderBox*);
136 136
137 LayoutUnit computeChildMarginValue(Length margin, RenderView*); 137 LayoutUnit computeChildMarginValue(Length margin, RenderView*);
138 void computeMainAxisPreferredSizes(Vector<int>&); 138 void prepareOrderIteratorAndMargins();
139 LayoutUnit adjustChildSizeForMinAndMax(RenderBox*, LayoutUnit childSize); 139 LayoutUnit adjustChildSizeForMinAndMax(RenderBox*, LayoutUnit childSize);
140 // The hypothetical main size of an item is the flex base size clamped accor ding to its min and max main size properties 140 // The hypothetical main size of an item is the flex base size clamped accor ding to its min and max main size properties
141 bool computeNextFlexLine(OrderedFlexItemList& orderedChildren, LayoutUnit& s umFlexBaseSize, double& totalFlexGrow, double& totalWeightedFlexShrink, LayoutUn it& sumHypotheticalMainSize, bool& hasInfiniteLineLength); 141 bool computeNextFlexLine(OrderedFlexItemList& orderedChildren, LayoutUnit& s umFlexBaseSize, double& totalFlexGrow, double& totalWeightedFlexShrink, LayoutUn it& sumHypotheticalMainSize, bool& hasInfiniteLineLength);
142 142
143 bool resolveFlexibleLengths(FlexSign, const OrderedFlexItemList&, LayoutUnit & availableFreeSpace, double& totalFlexGrow, double& totalWeightedFlexShrink, In flexibleFlexItemSize&, Vector<LayoutUnit>& childSizes, bool hasInfiniteLineLengt h); 143 bool resolveFlexibleLengths(FlexSign, const OrderedFlexItemList&, LayoutUnit & availableFreeSpace, double& totalFlexGrow, double& totalWeightedFlexShrink, In flexibleFlexItemSize&, Vector<LayoutUnit>& childSizes, bool hasInfiniteLineLengt h);
144 void freezeViolations(const Vector<Violation>&, LayoutUnit& availableFreeSpa ce, double& totalFlexGrow, double& totalWeightedFlexShrink, InflexibleFlexItemSi ze&, bool hasInfiniteLineLength); 144 void freezeViolations(const Vector<Violation>&, LayoutUnit& availableFreeSpa ce, double& totalFlexGrow, double& totalWeightedFlexShrink, InflexibleFlexItemSi ze&, bool hasInfiniteLineLength);
145 145
146 void resetAutoMarginsAndLogicalTopInCrossAxis(RenderBox*); 146 void resetAutoMarginsAndLogicalTopInCrossAxis(RenderBox*);
147 bool needToStretchChild(RenderBox*); 147 bool needToStretchChild(RenderBox*);
148 void setLogicalOverrideSize(RenderBox* child, LayoutUnit childPreferredSize) ; 148 void setLogicalOverrideSize(RenderBox* child, LayoutUnit childPreferredSize) ;
(...skipping 22 matching lines...) Expand all
171 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isFlexibleBox()); 171 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isFlexibleBox());
172 return static_cast<const RenderFlexibleBox*>(object); 172 return static_cast<const RenderFlexibleBox*>(object);
173 } 173 }
174 174
175 // This will catch anyone doing an unnecessary cast. 175 // This will catch anyone doing an unnecessary cast.
176 void toRenderFlexibleBox(const RenderFlexibleBox*); 176 void toRenderFlexibleBox(const RenderFlexibleBox*);
177 177
178 } // namespace WebCore 178 } // namespace WebCore
179 179
180 #endif // RenderFlexibleBox_h 180 #endif // RenderFlexibleBox_h
OLDNEW
« no previous file with comments | « Source/core/rendering/OrderIterator.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698