Setting up OrderIterator shouldn't require an extra Vector

Setting up OrderIterator shouldn't require an extra Vector

This change reuses the OrderIterator's Vector for fun and profit.
The idea is to have an helper class OrderIteratorPopulator, used for
manipulating the Vector directly.

The helper class has the nice upside of consolidating the code into a
single implementation across flexbox and grid.

Also tweaked the Vector to have an inline capacity for a single entry
that will cover the common case.

BUG=256804
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153971

[Julien - ping for review, 2013-07-10 19:10:47]

Pretty different approach than https://codereview.chromium.org/18133003 but same
result. Let me know what you think!

[cbiesinger, 2013-07-10 19:35:26]

lgtm

with the mentioned changes, lgtm. thanks!

[cbiesinger, 2013-07-10 19:35:32]

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/OrderIt...
File Source/core/rendering/OrderIterator.cpp (right):

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/OrderIt...
Source/core/rendering/OrderIterator.cpp:85: m_iterator.reset();
It feels weird to have this reset() call in the middle of setting up
m_orderValues. Maybe move it to the beginning or end of the destructor?

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/RenderF...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/RenderF...
Source/core/rendering/RenderFlexibleBox.cpp:872: void
RenderFlexibleBox::computeMainAxisPreferredSizes()
I think you should keep the rename of this function from
https://codereview.chromium.org/18133003

[ojan, 2013-07-10 20:48:38]

lgtm as well

[Julien - ping for review, 2013-07-10 21:15:48]

Thanks for the reviews!

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/OrderIt...
File Source/core/rendering/OrderIterator.cpp (right):

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/OrderIt...
Source/core/rendering/OrderIterator.cpp:85: m_iterator.reset();
On 2013/07/10 19:35:32, cbiesinger wrote:
> It feels weird to have this reset() call in the middle of setting up
> m_orderValues. Maybe move it to the beginning or end of the destructor?

Sounds good moved it to the beginning of the destructor.

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/RenderF...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/18978010/diff/1/Source/core/rendering/RenderF...
Source/core/rendering/RenderFlexibleBox.cpp:872: void
RenderFlexibleBox::computeMainAxisPreferredSizes()
On 2013/07/10 19:35:32, cbiesinger wrote:
> I think you should keep the rename of this function from
> https://codereview.chromium.org/18133003

Done.

[commit-bot: I haz the power, 2013-07-10 21:16:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/18978010/9001

[commit-bot: I haz the power, 2013-07-11 03:32:37]

Change committed as 153971