Issue 18911002: Move language detection to chrome/common/.

Issue 18911002: Move language detection to chrome/common/. (Closed)

Created:
7 years, 5 months ago by droger

Modified:
7 years, 5 months ago

Reviewers:
Takashi Toyoshima, blundell, jochen (gone - plz use gerrit), hajimehoshi

CC:
chromium-reviews, hajimehoshi

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move language detection to chrome/common/. This CL moves the language detection code from chrome/renderer/translate to chrome/common/translate, in order to be able to use it on iOS. This CL also enables the related unittests on iOS. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211108

Patch Set 1 : . #

Patch Set 2 : improved test #

Patch Set 3 : Fix unittest #

Patch Set 4 : Fix compile #

Patch Set 5 : Full test + rebase #

Total comments: 3

Patch Set 6 : Review comments #

Patch Set 7 : Rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+348 lines, -1773 lines)			Patch
M	build/common.gypi	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2 3 4 5 6	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 2 3 4 5 6	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3 4 5 6	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/translate/language_detection_util.h	View	1 2 3 4	1 chunk	+44 lines, -0 lines	0 comments	Download
A +	chrome/common/translate/language_detection_util.cc	View	1 2 3 4 5	7 chunks	+108 lines, -538 lines	0 comments	Download
A +	chrome/common/translate/language_detection_util_unittest.cc	View	1 2 3 4 5	3 chunks	+56 lines, -55 lines	0 comments	Download
A +	chrome/common/translate/translate_common_metrics.h	View	1 2 3 4 5	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/common/translate/translate_common_metrics.cc	View	1 2 3 4 5	3 chunks	+21 lines, -21 lines	0 comments	Download
A +	chrome/common/translate/translate_common_metrics_unittest.cc	View	1 2 3 4 5	4 chunks	+90 lines, -90 lines	0 comments	Download
M	chrome/renderer/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/translate/translate_helper.h	View		2 chunks	+0 lines, -42 lines	0 comments	Download
M	chrome/renderer/translate/translate_helper.cc	View	1 2 3 4 5	9 chunks	+8 lines, -293 lines	0 comments	Download
D	chrome/renderer/translate/translate_helper_metrics.h	View		1 chunk	+0 lines, -108 lines	0 comments	Download
D	chrome/renderer/translate/translate_helper_metrics.cc	View		1 chunk	+0 lines, -146 lines	0 comments	Download
D	chrome/renderer/translate/translate_helper_metrics_unittest.cc	View		1 chunk	+0 lines, -304 lines	0 comments	Download
D	chrome/renderer/translate/translate_helper_unittest.cc	View		1 chunk	+0 lines, -157 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

droger

This is mostly moving code around. Unfortunately, I am afraid it's a bit hard to ...

7 years, 5 months ago (2013-07-10 16:21:19 UTC) #1

Takashi Toyoshima

LGTM with one request. https://codereview.chromium.org/18911002/diff/22001/chrome/common/translate/translate_helper_metrics.h File chrome/common/translate/translate_helper_metrics.h (right): https://codereview.chromium.org/18911002/diff/22001/chrome/common/translate/translate_helper_metrics.h#newcode5 chrome/common/translate/translate_helper_metrics.h:5: #ifndef CHROME_COMMON_TRANSLATE_TRANSLATE_HELPER_METRICS_H_ Originally, TranslateHelperMetrics is ...

7 years, 5 months ago (2013-07-10 17:14:21 UTC) #2

hajimehoshi

https://codereview.chromium.org/18911002/diff/22001/chrome/common/translate/language_detection_util.cc File chrome/common/translate/language_detection_util.cc (right): https://codereview.chromium.org/18911002/diff/22001/chrome/common/translate/language_detection_util.cc#newcode1 chrome/common/translate/language_detection_util.cc:1: // Copyright (c) 2013 The Chromium Authors. All rights ...

7 years, 5 months ago (2013-07-11 07:34:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/18911002/54001

7 years, 5 months ago (2013-07-11 10:32:59 UTC) #7

Message was sent while issue was closed.

Change committed as 211108

Expand Messages | Collapse Messages