Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4696)

Unified Diff: chrome/common/translate/translate_common_metrics.cc

Issue 18911002: Move language detection to chrome/common/. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/translate/translate_common_metrics.cc
diff --git a/chrome/renderer/translate/translate_helper_metrics.cc b/chrome/common/translate/translate_common_metrics.cc
similarity index 79%
rename from chrome/renderer/translate/translate_helper_metrics.cc
rename to chrome/common/translate/translate_common_metrics.cc
index 93ce5b0b9c72066ee3d4bb235459e5e276cc29f5..028be6db5284a48e495fedf0238196221b6a9e6a 100644
--- a/chrome/renderer/translate/translate_helper_metrics.cc
+++ b/chrome/common/translate/translate_common_metrics.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/translate/translate_helper_metrics.h"
+#include "chrome/common/translate/translate_common_metrics.h"
#include "base/basictypes.h"
#include "base/metrics/histogram.h"
@@ -26,63 +26,63 @@ const char kSchemeHttp[] = "http";
const char kSchemeHttps[] = "https";
struct MetricsEntry {
- TranslateHelperMetrics::MetricsNameIndex index;
+ TranslateCommonMetrics::MetricsNameIndex index;
const char* const name;
};
// This entry table should be updated when new UMA items are added.
const MetricsEntry kMetricsEntries[] = {
- { TranslateHelperMetrics::UMA_LANGUAGE_DETECTION,
+ { TranslateCommonMetrics::UMA_LANGUAGE_DETECTION,
kRenderer4LanguageDetection },
- { TranslateHelperMetrics::UMA_CONTENT_LANGUAGE,
+ { TranslateCommonMetrics::UMA_CONTENT_LANGUAGE,
kTranslateContentLanguage },
- { TranslateHelperMetrics::UMA_HTML_LANG,
+ { TranslateCommonMetrics::UMA_HTML_LANG,
kTranslateHtmlLang },
- { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION,
+ { TranslateCommonMetrics::UMA_LANGUAGE_VERIFICATION,
kTranslateLanguageVerification },
- { TranslateHelperMetrics::UMA_TIME_TO_BE_READY,
+ { TranslateCommonMetrics::UMA_TIME_TO_BE_READY,
kTranslateTimeToBeReady },
- { TranslateHelperMetrics::UMA_TIME_TO_LOAD,
+ { TranslateCommonMetrics::UMA_TIME_TO_LOAD,
kTranslateTimeToLoad },
- { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE,
+ { TranslateCommonMetrics::UMA_TIME_TO_TRANSLATE,
kTranslateTimeToTranslate },
- { TranslateHelperMetrics::UMA_USER_ACTION_DURATION,
+ { TranslateCommonMetrics::UMA_USER_ACTION_DURATION,
kTranslateUserActionDuration },
- { TranslateHelperMetrics::UMA_PAGE_SCHEME,
+ { TranslateCommonMetrics::UMA_PAGE_SCHEME,
kTranslatePageScheme },
- { TranslateHelperMetrics::UMA_SIMILAR_LANGUAGE_MATCH,
+ { TranslateCommonMetrics::UMA_SIMILAR_LANGUAGE_MATCH,
kTranslateSimilarLanguageMatch },
};
-COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateHelperMetrics::UMA_MAX,
+COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateCommonMetrics::UMA_MAX,
arraysize_of_kMetricsEntries_should_be_UMA_MAX);
-TranslateHelperMetrics::LanguageCheckType GetLanguageCheckMetric(
+TranslateCommonMetrics::LanguageCheckType GetLanguageCheckMetric(
const std::string& provided_code,
const std::string& revised_code) {
if (provided_code.empty())
- return TranslateHelperMetrics::LANGUAGE_NOT_PROVIDED;
+ return TranslateCommonMetrics::LANGUAGE_NOT_PROVIDED;
else if (provided_code == revised_code)
- return TranslateHelperMetrics::LANGUAGE_VALID;
- return TranslateHelperMetrics::LANGUAGE_INVALID;
+ return TranslateCommonMetrics::LANGUAGE_VALID;
+ return TranslateCommonMetrics::LANGUAGE_INVALID;
}
} // namespace
-namespace TranslateHelperMetrics {
+namespace TranslateCommonMetrics {
void ReportContentLanguage(const std::string& provided_code,
const std::string& revised_code) {
UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
GetLanguageCheckMetric(provided_code, revised_code),
- TranslateHelperMetrics::LANGUAGE_MAX);
+ TranslateCommonMetrics::LANGUAGE_MAX);
}
void ReportHtmlLang(const std::string& provided_code,
const std::string& revised_code) {
UMA_HISTOGRAM_ENUMERATION(kTranslateHtmlLang,
GetLanguageCheckMetric(provided_code, revised_code),
- TranslateHelperMetrics::LANGUAGE_MAX);
+ TranslateCommonMetrics::LANGUAGE_MAX);
}
void ReportLanguageVerification(LanguageVerificationType type) {
@@ -143,4 +143,4 @@ const char* GetMetricsName(MetricsNameIndex index) {
return NULL;
}
-} // namespace TranslateHelperMetrics
+} // namespace TranslateCommonMetrics
« no previous file with comments | « chrome/common/translate/translate_common_metrics.h ('k') | chrome/common/translate/translate_common_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698