Issue 18873009: Revert "Revert "Remove dependencies on /media for iOS.""

Issue 18873009: Revert "Revert "Remove dependencies on /media for iOS."" (Closed)

Created:
7 years, 5 months ago by bdibello-goog

Modified:
7 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert "Revert "Remove dependencies on /media for iOS."" This reverts commit 1f99bc28b47392ed97d03863460bc681d7f39a1a. /media was only needed for the old version of voice search on iOS. BUG=227855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219867

Patch Set 1 #

Patch Set 2 : Sync and fix merge conflicts. #

Patch Set 3 : Re-upload patch #

Patch Set 4 : Re-upload patch #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
M	build/all.gyp	View	1	4 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	4 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
	content/content_common.gypi	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1	4 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/test/content_test_suite_base.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bdibello-goog

No changes from the original CL: https://chromiumcodereview.appspot.com/18777006. That had to be reverted due to the ...

7 years, 5 months ago (2013-07-12 17:09:08 UTC) #1

bdibello-goog

Bots have been updated to no longer run media_unittests for iOS. John, could you re-review ...

7 years, 4 months ago (2013-08-01 10:10:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bdibello@google.com/18873009/20001

7 years, 3 months ago (2013-08-27 13:20:47 UTC) #6

Message was sent while issue was closed.

Change committed as 219867

Expand Messages | Collapse Messages