Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 18777006: Remove dependencies on /media for iOS. (Closed)

Created:
7 years, 5 months ago by bdibello-goog
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove dependencies on /media for iOS. /media was only needed for the old version of voice search on iOS. BUG=227855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M build/all.gyp View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/content_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bdibello-goog
7 years, 5 months ago (2013-07-09 15:32:05 UTC) #1
jam
lgtm
7 years, 5 months ago (2013-07-09 18:10:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bdibello@google.com/18777006/1
7 years, 5 months ago (2013-07-10 11:16:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=133767
7 years, 5 months ago (2013-07-10 15:05:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bdibello@google.com/18777006/1
7 years, 5 months ago (2013-07-10 15:15:53 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 18:53:00 UTC) #6
Message was sent while issue was closed.
Change committed as 210900

Powered by Google App Engine
This is Rietveld 408576698